Update CONTRIBUTING.md. #549

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
4 participants
@nex3
Member

nex3 commented Feb 21, 2017

This brings in changes from dart-lang/oss_project_templates#10 and adds
some extra test-specific information.

Closes #535

Update CONTRIBUTING.md.
This brings in changes from dart-lang/oss_project_templates#10 and adds
some extra test-specific information.

Closes #535

@googlebot googlebot added the cla: yes label Feb 21, 2017

@nex3 nex3 requested a review from eseidelGoogle Feb 21, 2017

@eseidelGoogle

This comment has been minimized.

Show comment
Hide comment
@eseidelGoogle

eseidelGoogle Feb 21, 2017

I'm not the right reviewer for this (maybe @kevmoo or @devoncarew?), but rslgtm. :) It feels a bit odd to put all the legal bits as the first thing (are we discouraging contributions?) but honestly I'm just glad to know all the bits about testing. When I tried to run the tests I didn't have content_shell in my path which probably caused some of the failures I saw trying to work up a package:test patch! :)

I'm not the right reviewer for this (maybe @kevmoo or @devoncarew?), but rslgtm. :) It feels a bit odd to put all the legal bits as the first thing (are we discouraging contributions?) but honestly I'm just glad to know all the bits about testing. When I tried to run the tests I didn't have content_shell in my path which probably caused some of the failures I saw trying to work up a package:test patch! :)

@kevmoo

kevmoo approved these changes Feb 21, 2017

@nex3 nex3 merged commit 94ab7f0 into master Feb 21, 2017

1 check passed

cla/google All necessary CLAs are signed

@nex3 nex3 deleted the contributing branch Feb 21, 2017

@eseidelGoogle

This comment has been minimized.

Show comment
Hide comment
@eseidelGoogle

eseidelGoogle Feb 22, 2017

Thank you very much. :)

Thank you very much. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment