Zone.strong #684
Merged
Zone.strong #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Sep 18, 2017
| @@ -1,5 +1,5 @@ | |||
| name: test | |||
| version: 0.12.24+5 | |||
| version: 0.12.24+6 | |||
Member
There was a problem hiding this comment.
Do we need to update the minimum sdk version as well?
Contributor
Author
There was a problem hiding this comment.
No. This change should maintain the same semantics.
Contributor
Author
|
I added a Changelog entry. |
grouma
approved these changes
Sep 18, 2017
Member
grouma
left a comment
grouma
left a comment
There was a problem hiding this comment.
LGTM assuming Travis passes. I'll handle publishing if you want.
Member
|
@floitschG It looks like as of 2.0.0-dev.1.0, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dart:asynczone API is in the process of becoming strong-mode clean.This patch fixes a breakage introduced by this change.
The change should have no semantic difference, even when running with the non-strong zone API.