Skip to content

Conversation

@greglittlefield-wf
Copy link
Contributor

Problem

I hit an error earlier when running tests in a repo whose dependencies hadn't been updated in a while:

NoSuchMethodError: No static method 'capture' with matching arguments declared in class 'Chain'.
Receiver: Type: class 'Chain'
Tried calling: capture(Closure: () => dynamic, when: true)
Found: capture(() => dynamic, {ChainHandler onError})
#0      NoSuchMethodError._throwNew (dart:core-patch/errors_patch.dart:196)
#1      Invoker._onRun (package:test/src/backend/invoker.dart:336)
...

The when parameter to Chain.capture is currently used in invoker.dart#L388, which wasn't added until stack_trace 1.6.0.

Solution

Bump minimum version of stack_trace to ensure this error doesn't happen.

The `when` parameter to `Chain.capture` is currently used,
which was added in stack_trace 1.6.0.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@greglittlefield-wf
Copy link
Contributor Author

My company (Workiva) signed it!

@kevmoo kevmoo requested review from grouma and nex3 October 27, 2017 22:24
@grouma grouma merged commit 9bc2e03 into dart-lang:master Oct 27, 2017
@natebosch
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants