-
Notifications
You must be signed in to change notification settings - Fork 77
Bump min Dart SDK to 3.9, reformat #2251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the minimum Dart SDK version to ^3.9.0 and applies the corresponding code formatting changes across the package. The SDK version update is correctly reflected in pubspec.yaml and CHANGELOG.md. A new lint rule, remove_deprecations_in_breaking_versions, has also been added to analysis_options.yaml. The numerous formatting changes are consistent with the latest dart format style, improving code readability and maintainability. The changes are correct and well-executed. This PR is good to merge.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Pull Request Test Coverage Report for Build 19520577800Details
💛 - Coveralls |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| markdown | Non-Breaking | 7.3.0 | 7.3.1-wip | 7.4.0 Got "7.3.1-wip" expected >= "7.4.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/markdown/example/app.dart | 💔 Not covered |
| pkgs/markdown/lib/src/assets/case_folding.dart | 💔 Not covered |
| pkgs/markdown/lib/src/assets/html_entities.dart | 💔 Not covered |
| pkgs/markdown/lib/src/ast.dart | 💚 100 % |
| pkgs/markdown/lib/src/block_parser.dart | 💚 91 % |
| pkgs/markdown/lib/src/block_syntaxes/alert_block_syntax.dart | 💚 87 % ⬆️ 2 % |
| pkgs/markdown/lib/src/block_syntaxes/block_syntax.dart | 💚 76 % ⬆️ 3 % |
| pkgs/markdown/lib/src/block_syntaxes/blockquote_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/block_syntaxes/code_block_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/block_syntaxes/fenced_code_block_syntax.dart | 💚 98 % |
| pkgs/markdown/lib/src/block_syntaxes/footnote_def_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/block_syntaxes/link_reference_definition_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/block_syntaxes/list_syntax.dart | 💚 94 % |
| pkgs/markdown/lib/src/block_syntaxes/table_syntax.dart | 💚 90 % |
| pkgs/markdown/lib/src/document.dart | 💚 95 % |
| pkgs/markdown/lib/src/extension_set.dart | 💔 95 % ⬇️ 1 % |
| pkgs/markdown/lib/src/html_renderer.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_parser.dart | 💚 98 % ⬆️ 0 % |
| pkgs/markdown/lib/src/inline_syntaxes/autolink_extension_syntax.dart | 💚 98 % |
| pkgs/markdown/lib/src/inline_syntaxes/autolink_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/color_swatch_syntax.dart | 💔 27 % ⬇️ 13 % |
| pkgs/markdown/lib/src/inline_syntaxes/decode_html_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/delimiter_syntax.dart | 💔 88 % ⬇️ 2 % |
| pkgs/markdown/lib/src/inline_syntaxes/emphasis_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/escape_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/footnote_ref_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/image_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/inline_html_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/inline_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/link_syntax.dart | 💚 99 % |
| pkgs/markdown/lib/src/inline_syntaxes/strikethrough_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/line.dart | 💚 100 % |
| pkgs/markdown/lib/src/patterns.dart | 💚 100 % |
| pkgs/markdown/lib/src/util.dart | 💚 100 % |
| pkgs/markdown/tool/dartdoc_compare.dart | 💔 Not covered |
| pkgs/markdown/tool/expected_output.dart | 💔 Not covered |
| pkgs/markdown/tool/stats.dart | 💔 Not covered |
| pkgs/markdown/tool/stats_lib.dart | 💔 Not covered |
| pkgs/markdown/tool/update_case_folding.dart | 💔 Not covered |
| pkgs/markdown/tool/update_emojis.dart | 💔 Not covered |
| pkgs/markdown/tool/update_entities.dart | 💔 Not covered |
| pkgs/markdown/tool/update_github_emojis.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
srawlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Win!
No description provided.