-
Notifications
You must be signed in to change notification settings - Fork 76
Add playback from logs to watcher e2e test, start collection of test cases. #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
37df8a9 to
73bbfdd
Compare
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| watcher | Non-Breaking | 1.1.4 | 1.1.5-wip | 1.2.0 Got "1.1.5-wip" expected >= "1.2.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ✔️
| File | Coverage |
|---|
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
73bbfdd to
a1f9e51
Compare
The random and seeded tests are good, to actually make progress on the hard cases I need to minimize+keep the important randomly-generated tests.
So: log playback :) and a first test case from it, skipped on Linux since it doesn't pass right now.
Most of the new
end_to_end_test_runner.dartis moved out ofend_to_end_tests.dartrather than new code, then updated for the new option of passing a log. I don't know how to make GitHub show a better diff for that, sorry!