Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to IDLs version 3.43.1 #160

Merged
merged 1 commit into from
Feb 8, 2024
Merged

update to IDLs version 3.43.1 #160

merged 1 commit into from
Feb 8, 2024

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Feb 7, 2024

  • update to IDLs version 3.43.1

Update to the latest IDLs. We need to generate the library for the css-view-transitions IDL as the html idl references its types (otherwise we wouldn't generate css-view-transitions, as the ViewTransition API is standards-track but only supported by chrome).

As we are emitting some code that we otherwise wouldn't, it could be useful to emit some dartdoc or annotations which clarified on which platforms an API was available.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devoncarew
Copy link
Member Author

landing; cc @srujzs

@devoncarew devoncarew merged commit 39bcace into main Feb 8, 2024
11 checks passed
@devoncarew devoncarew deleted the 3.43.1 branch February 8, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants