Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getters should be marked with isGetter when fetching class definitions with getObject() #2184

Closed
DanTup opened this issue Aug 8, 2023 · 2 comments

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 8, 2023

dart-lang/sdk#52920 added a new isGetter field to members returned in class definitions via getObject(), but it's not currently populated by DWDS:

{
	"type": "@Function",
	"id": "methods|classes|package:flutter_hello_world/getters.dart|Danny|kind",
	"name": "kind",
	"owner": {
		"type": "@Class",
		"id": "classes|package:flutter_hello_world/getters.dart|Danny",
		"name": "Danny",
		"library": {
			"type": "@Library",
			"id": "package:flutter_hello_world/getters.dart",
			"name": "package:flutter_hello_world/getters.dart",
			"uri": "package:flutter_hello_world/getters.dart"
		}
	},
	"static": false,
	"const": false,
	"implicit": false,
	"abstract": false,
	"isGetter": false, // <-- expected to be true
	"isSetter": false
},

DAP isn't using isGetter yet (it currently checks f.json?['_kind'] == 'GetterFunction which also isn't true here), but I'm going to switch it over to that shortly.

@annagrin
Copy link
Contributor

annagrin commented Aug 8, 2023

@DanTup this should be now resolved with #2159. Please let me know if it still not showing as expected.

@DanTup
Copy link
Contributor Author

DanTup commented Oct 17, 2023

Sorry for the delay - yes, I can see isGetter populated now. Thanks! :-)

@DanTup DanTup closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants