Improve logging in tests #1368
Merged
Improve logging in tests #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Jul 23, 2021
natebosch
approved these changes
Jul 29, 2021
added 5 commits
August 3, 2021 13:57
- log http requests and to asset server, log request exceptions - make setting up logger more convenient by providing default loggers - log exceptions and stack traces in default loggers
annagrin
force-pushed
the
annagrin/improve_logging
branch
from
ceefb21 to
e47b57f
Compare
grouma
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the rest of the code
since it runs in an isolate and we cannot redirect stdout/stderr to logs.
Postpone redirecting output until expression_compiler_worker moves to
a process.