From e5b885fe377ad4cdbee36371c927c25972f1bc0a Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 27 Feb 2023 11:07:51 -0800 Subject: [PATCH 1/2] Ignore page reloads for dismounting extension --- dwds/debug_extension_mv3/web/background.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/dwds/debug_extension_mv3/web/background.dart b/dwds/debug_extension_mv3/web/background.dart index eea554cf7..6ea64f47a 100644 --- a/dwds/debug_extension_mv3/web/background.dart +++ b/dwds/debug_extension_mv3/web/background.dart @@ -163,6 +163,7 @@ bool _isInternalNavigation(NavigationInfo navigationInfo) { 'form_submit', 'link', 'manual_subframe', + 'reload', ].contains(navigationInfo.transitionType); } From 2a15405ccf24bbff48d066c2df34ae49e4ad761e Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 27 Feb 2023 11:09:22 -0800 Subject: [PATCH 2/2] Update comment --- dwds/debug_extension_mv3/web/background.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/debug_extension_mv3/web/background.dart b/dwds/debug_extension_mv3/web/background.dart index 6ea64f47a..878b79e7f 100644 --- a/dwds/debug_extension_mv3/web/background.dart +++ b/dwds/debug_extension_mv3/web/background.dart @@ -140,7 +140,7 @@ Future _handleRuntimeMessages( Future _detectNavigationAwayFromDartApp( NavigationInfo navigationInfo) async { // Ignore any navigation events within the page itself (e.g., opening a link, - // reloading an IFRAME, etc): + // reloading the page, reloading an IFRAME, etc): if (_isInternalNavigation(navigationInfo)) return; final tabId = navigationInfo.tabId; final debugInfo = await _fetchDebugInfo(navigationInfo.tabId);