From a52e6c8d7d1d84f22b8b15c8b1289b287398a418 Mon Sep 17 00:00:00 2001 From: Srujan Gaddam Date: Thu, 9 Oct 2025 14:41:55 -0700 Subject: [PATCH] [DWDS] Make pause a no-op on WebSocketProxyService We can't actually pause during execution so we shouldn't signal that we did. --- dwds/CHANGELOG.md | 5 +++++ .../src/services/web_socket_proxy_service.dart | 18 ++---------------- dwds/lib/src/version.dart | 2 +- dwds/pubspec.yaml | 2 +- 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index bc9ece36c..9bfd99e19 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -1,3 +1,8 @@ +## 26.1.0-wip + +- `pause` now does not send a `PauseInterrupted` event in + `WebSocketProxyService` as we didn't actually pause. + ## 26.0.0 - Bump SDK constraint to ^3.10.0 diff --git a/dwds/lib/src/services/web_socket_proxy_service.dart b/dwds/lib/src/services/web_socket_proxy_service.dart index 5b98a2132..cb97514f3 100644 --- a/dwds/lib/src/services/web_socket_proxy_service.dart +++ b/dwds/lib/src/services/web_socket_proxy_service.dart @@ -940,22 +940,8 @@ class WebSocketProxyService extends ProxyService { /// Pauses execution of the isolate. @override Future pause(String isolateId) => - wrapInErrorHandlerAsync('pause', () => _pause(isolateId)); - - Future _pause(String _) async { - // Create a pause event and store it - if (_isolateRef != null) { - final pauseEvent = vm_service.Event( - kind: vm_service.EventKind.kPauseInterrupted, - timestamp: DateTime.now().millisecondsSinceEpoch, - isolate: _isolateRef!, - ); - _currentPauseEvent = pauseEvent; - _streamNotify(vm_service.EventStreams.kDebug, pauseEvent); - } - - return Success(); - } + // Can't pause with the web socket implementation, so do nothing. + Future.value(Success()); /// Resumes execution of the isolate. @override diff --git a/dwds/lib/src/version.dart b/dwds/lib/src/version.dart index e564a30fb..0b0c9bb3b 100644 --- a/dwds/lib/src/version.dart +++ b/dwds/lib/src/version.dart @@ -1,2 +1,2 @@ // Generated code. Do not modify. -const packageVersion = '26.0.0'; +const packageVersion = '26.1.0-wip'; diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index 9e3ea3eb5..53b399218 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -1,6 +1,6 @@ name: dwds # Every time this changes you need to run `dart run build_runner build`. -version: 26.0.0 +version: 26.1.0-wip description: >- A service that proxies between the Chrome debug protocol and the Dart VM