zerolog: refactor considering data is encoded immediatelly on an internal buffer #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amery
force-pushed
the
pr-amery-zerolog
branch
from
d2a7789
to
c5e99e1
Compare
karasz
requested changes
Jan 18, 2023
There was a problem hiding this comment.
I am not a fan of GetEvent as it returns two unrelated results. Either I do not understand the code or GetEvent() should only return ev, for the bool value one should just call zl.Enabled() as that is also exported. So again IMVHO you either unexport Enabled() and rely on GetEvent() or drop the bool from GetEvent() and leave Enabled as exported. I lean towards the later.
method changed to mimick what *Event provides, and when there is an event we also use it to know if the logging should proceed Signed-off-by: Alejandro Mery <amery@jpi.io>
Signed-off-by: Alejandro Mery <amery@jpi.io>
…Contexts Signed-off-by: Alejandro Mery <amery@jpi.io>
…ctly supported by zerolog the event is a buffer, so calling Interface for each item is the same as calling zerolog's Fields() would do Signed-off-by: Alejandro Mery <amery@jpi.io>
amery
force-pushed
the
pr-amery-zerolog
branch
from
c5e99e1
to
695c8f4
Compare
|
@karasz amended. split in 4 more meaningful commits now. I got rid of GetEvent() |
amery
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have read zerolog's code before making assumptions