Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[Mac] Record backtrace with nsexception logging.

It has been suggested that the HALPropertyListener_Call_Helper()
crashes may be correlated with nsexception = "NSPortTimeoutException
reason connection timeout: did not receive reply".  One of the
whitelisted cases involves enumerating devices, so that could be
related.  This will record the backtrace where the exception is
throwing from.

BUG=158170

Review URL: https://codereview.chromium.org/12611026

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@189458 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
  • Loading branch information...
commit 8b398d9bbb67a2afc7c544dda54bf355dda3c7bb 1 parent 8c171d1
shess@chromium.org authored
Showing with 3 additions and 0 deletions.
  1. +3 −0  chrome_browser_application_mac.mm
View
3  chrome_browser_application_mac.mm
@@ -6,6 +6,7 @@
#import "base/auto_reset.h"
#include "base/debug/crash_logging.h"
+#include "base/debug/stack_trace.h"
#import "base/logging.h"
#import "base/mac/scoped_nsexception_enabler.h"
#import "base/memory/scoped_nsobject.h"
@@ -66,6 +67,8 @@ - (id)crInitWithName:(NSString*)aName
std::string value = base::StringPrintf("%s reason %s",
[aName UTF8String], [aReason UTF8String]);
base::debug::SetCrashKeyValue(crash_keys::mac::kNSException, value);
+ base::debug::SetCrashKeyToStackTrace(crash_keys::mac::kNSExceptionTrace,
+ base::debug::StackTrace());
// Force crash for selected exceptions to generate crash dumps.
BOOL fatal = NO;
Please sign in to comment.
Something went wrong with that request. Please try again.