Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

content: Move all listeners of NOTIFICATION_RENDER_VIEW_HOST_CREATED …

…out of content.

This is a prerequisite of converting NOTIFICATION_RENDER_VIEW_HOST_CREATED
to listeners of RenderViewCreated callback propagated through ContentBrowserClient
in chrome.

BUG=170921

Review URL: https://codereview.chromium.org/12832004

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@188840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
  • Loading branch information...
commit e3390980dd29b85677954ee607892bbe0ad0934c 1 parent 0624e44
phajdan.jr@chromium.org authored
1  download/download_browsertest.cc
@@ -1177,7 +1177,6 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadResourceThrottleCancels) {
1177 1177 content::TestNavigationObserver observer(
1178 1178 content::Source<content::NavigationController>(
1179 1179 &web_contents->GetController()),
1180   - NULL,
1181 1180 1);
1182 1181 bool download_assempted;
1183 1182 ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
1  errorpage_browsertest.cc
@@ -94,7 +94,6 @@ class ErrorPageTest : public InProcessBrowserTest {
94 94 content::Source<NavigationController>(
95 95 &browser()->tab_strip_model()->GetActiveWebContents()->
96 96 GetController()),
97   - NULL,
98 97 num_navigations);
99 98 if (direction == HISTORY_NAVIGATE_BACK) {
100 99 chrome::GoBack(browser(), CURRENT_TAB);
1  extensions/app_process_apitest.cc
@@ -612,7 +612,6 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, OpenAppFromExtension) {
612 612 // 3. The app's URL.
613 613 content::TestNavigationObserver test_navigation_observer(
614 614 content::NotificationService::AllSources(),
615   - NULL,
616 615 3);
617 616
618 617 // Load the launcher extension, which should launch the app.
2  history/redirect_browsertest.cc
@@ -281,7 +281,7 @@ IN_PROC_BROWSER_TEST_F(RedirectTest,
281 281 content::TestNavigationObserver observer(
282 282 content::Source<content::NavigationController>(
283 283 &web_contents->GetController()),
284   - NULL, 2);
  284 + 2);
285 285
286 286 ui_test_utils::NavigateToURLWithDisposition(
287 287 browser(), first_url, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
2  managed_mode/managed_mode_resource_throttle_browsertest.cc
@@ -48,7 +48,7 @@ IN_PROC_BROWSER_TEST_F(ManagedModeResourceThrottleTest, NoNavigationObserver) {
48 48 WebContents::Create(WebContents::CreateParams(browser()->profile())));
49 49 NavigationController& controller = web_contents->GetController();
50 50 content::TestNavigationObserver observer(
51   - content::Source<NavigationController>(&controller), NULL, 1);
  51 + content::Source<NavigationController>(&controller), 1);
52 52 controller.LoadURL(GURL("http://www.example.com"), content::Referrer(),
53 53 content::PAGE_TRANSITION_TYPED, std::string());
54 54 observer.Wait();
2  performance_monitor/performance_monitor_browsertest.cc
@@ -369,7 +369,7 @@ class PerformanceMonitorSessionRestoreBrowserTest
369 369 // Create a new window, which should trigger session restore.
370 370 ui_test_utils::BrowserAddedObserver window_observer;
371 371 content::TestNavigationObserver navigation_observer(
372   - content::NotificationService::AllSources(), NULL, expected_tab_count);
  372 + content::NotificationService::AllSources(), expected_tab_count);
373 373 chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
374 374 Browser* new_browser = window_observer.WaitForSingleNewBrowser();
375 375 navigation_observer.Wait();
2  prerender/prerender_browsertest.cc
@@ -1154,7 +1154,7 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {
1154 1154 // We don't expect to pick up a running prerender, so instead
1155 1155 // observe one navigation.
1156 1156 content::TestNavigationObserver observer(
1157   - content::NotificationService::AllSources(), NULL, 1);
  1157 + content::NotificationService::AllSources(), 1);
1158 1158 base::RunLoop run_loop;
1159 1159 observer.WaitForObservation(
1160 1160 base::Bind(&content::RunThisRunLoop,
2  sessions/session_restore_browsertest.cc
@@ -124,7 +124,7 @@ class SessionRestoreTest : public InProcessBrowserTest {
124 124 // Create a new window, which should trigger session restore.
125 125 ui_test_utils::BrowserAddedObserver window_observer;
126 126 content::TestNavigationObserver navigation_observer(
127   - content::NotificationService::AllSources(), NULL, expected_tab_count);
  127 + content::NotificationService::AllSources(), expected_tab_count);
128 128 chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
129 129 Browser* new_browser = window_observer.WaitForSingleNewBrowser();
130 130 navigation_observer.Wait();
1  ui/browser_browsertest.cc
@@ -1930,7 +1930,6 @@ class ClickModifierTest : public InProcessBrowserTest {
1930 1930 web_contents ? &web_contents->GetController() : NULL;
1931 1931 content::TestNavigationObserver same_tab_observer(
1932 1932 content::Source<NavigationController>(controller),
1933   - NULL,
1934 1933 1);
1935 1934 SimulateMouseClick(web_contents, modifiers, button);
1936 1935 base::RunLoop run_loop;
4 ui/fullscreen/fullscreen_controller_test.cc
@@ -86,7 +86,7 @@ void FullscreenControllerTest::DenyCurrentFullscreenOrMouseLockRequest() {
86 86
87 87 void FullscreenControllerTest::GoBack() {
88 88 content::TestNavigationObserver observer(
89   - content::NotificationService::AllSources(), NULL, 1);
  89 + content::NotificationService::AllSources(), 1);
90 90
91 91 chrome::GoBack(browser(), CURRENT_TAB);
92 92
@@ -95,7 +95,7 @@ void FullscreenControllerTest::GoBack() {
95 95
96 96 void FullscreenControllerTest::Reload() {
97 97 content::TestNavigationObserver observer(
98   - content::NotificationService::AllSources(), NULL, 1);
  98 + content::NotificationService::AllSources(), 1);
99 99
100 100 chrome::Reload(browser(), CURRENT_TAB);
101 101
2  ui/webui/bookmarks_ui_browsertest.cc
@@ -22,7 +22,7 @@ class BookmarksTest : public InProcessBrowserTest {
22 22
23 23 void OpenBookmarksManager() {
24 24 content::TestNavigationObserver navigation_observer(
25   - content::NotificationService::AllSources(), NULL, 2);
  25 + content::NotificationService::AllSources(), 2);
26 26
27 27 // Bring up the bookmarks manager tab.
28 28 chrome::ShowBookmarkManager(browser());

0 comments on commit e339098

Please sign in to comment.
Something went wrong with that request. Please try again.