Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

content: Move all listeners of NOTIFICATION_RENDER_VIEW_HOST_CREATED …

…out of content.

This is a prerequisite of converting NOTIFICATION_RENDER_VIEW_HOST_CREATED
to listeners of RenderViewCreated callback propagated through ContentBrowserClient
in chrome.

BUG=170921

Review URL: https://codereview.chromium.org/12832004

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@188840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
  • Loading branch information...
commit e3390980dd29b85677954ee607892bbe0ad0934c 1 parent 0624e44
phajdan.jr@chromium.org authored
View
1  download/download_browsertest.cc
@@ -1177,7 +1177,6 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadResourceThrottleCancels) {
content::TestNavigationObserver observer(
content::Source<content::NavigationController>(
&web_contents->GetController()),
- NULL,
1);
bool download_assempted;
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
View
1  errorpage_browsertest.cc
@@ -94,7 +94,6 @@ class ErrorPageTest : public InProcessBrowserTest {
content::Source<NavigationController>(
&browser()->tab_strip_model()->GetActiveWebContents()->
GetController()),
- NULL,
num_navigations);
if (direction == HISTORY_NAVIGATE_BACK) {
chrome::GoBack(browser(), CURRENT_TAB);
View
1  extensions/app_process_apitest.cc
@@ -612,7 +612,6 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, OpenAppFromExtension) {
// 3. The app's URL.
content::TestNavigationObserver test_navigation_observer(
content::NotificationService::AllSources(),
- NULL,
3);
// Load the launcher extension, which should launch the app.
View
2  history/redirect_browsertest.cc
@@ -281,7 +281,7 @@ IN_PROC_BROWSER_TEST_F(RedirectTest,
content::TestNavigationObserver observer(
content::Source<content::NavigationController>(
&web_contents->GetController()),
- NULL, 2);
+ 2);
ui_test_utils::NavigateToURLWithDisposition(
browser(), first_url, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
View
2  managed_mode/managed_mode_resource_throttle_browsertest.cc
@@ -48,7 +48,7 @@ IN_PROC_BROWSER_TEST_F(ManagedModeResourceThrottleTest, NoNavigationObserver) {
WebContents::Create(WebContents::CreateParams(browser()->profile())));
NavigationController& controller = web_contents->GetController();
content::TestNavigationObserver observer(
- content::Source<NavigationController>(&controller), NULL, 1);
+ content::Source<NavigationController>(&controller), 1);
controller.LoadURL(GURL("http://www.example.com"), content::Referrer(),
content::PAGE_TRANSITION_TYPED, std::string());
observer.Wait();
View
2  performance_monitor/performance_monitor_browsertest.cc
@@ -369,7 +369,7 @@ class PerformanceMonitorSessionRestoreBrowserTest
// Create a new window, which should trigger session restore.
ui_test_utils::BrowserAddedObserver window_observer;
content::TestNavigationObserver navigation_observer(
- content::NotificationService::AllSources(), NULL, expected_tab_count);
+ content::NotificationService::AllSources(), expected_tab_count);
chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
navigation_observer.Wait();
View
2  prerender/prerender_browsertest.cc
@@ -1154,7 +1154,7 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {
// We don't expect to pick up a running prerender, so instead
// observe one navigation.
content::TestNavigationObserver observer(
- content::NotificationService::AllSources(), NULL, 1);
+ content::NotificationService::AllSources(), 1);
base::RunLoop run_loop;
observer.WaitForObservation(
base::Bind(&content::RunThisRunLoop,
View
2  sessions/session_restore_browsertest.cc
@@ -124,7 +124,7 @@ class SessionRestoreTest : public InProcessBrowserTest {
// Create a new window, which should trigger session restore.
ui_test_utils::BrowserAddedObserver window_observer;
content::TestNavigationObserver navigation_observer(
- content::NotificationService::AllSources(), NULL, expected_tab_count);
+ content::NotificationService::AllSources(), expected_tab_count);
chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
navigation_observer.Wait();
View
1  ui/browser_browsertest.cc
@@ -1930,7 +1930,6 @@ class ClickModifierTest : public InProcessBrowserTest {
web_contents ? &web_contents->GetController() : NULL;
content::TestNavigationObserver same_tab_observer(
content::Source<NavigationController>(controller),
- NULL,
1);
SimulateMouseClick(web_contents, modifiers, button);
base::RunLoop run_loop;
View
4 ui/fullscreen/fullscreen_controller_test.cc
@@ -86,7 +86,7 @@ void FullscreenControllerTest::DenyCurrentFullscreenOrMouseLockRequest() {
void FullscreenControllerTest::GoBack() {
content::TestNavigationObserver observer(
- content::NotificationService::AllSources(), NULL, 1);
+ content::NotificationService::AllSources(), 1);
chrome::GoBack(browser(), CURRENT_TAB);
@@ -95,7 +95,7 @@ void FullscreenControllerTest::GoBack() {
void FullscreenControllerTest::Reload() {
content::TestNavigationObserver observer(
- content::NotificationService::AllSources(), NULL, 1);
+ content::NotificationService::AllSources(), 1);
chrome::Reload(browser(), CURRENT_TAB);
View
2  ui/webui/bookmarks_ui_browsertest.cc
@@ -22,7 +22,7 @@ class BookmarksTest : public InProcessBrowserTest {
void OpenBookmarksManager() {
content::TestNavigationObserver navigation_observer(
- content::NotificationService::AllSources(), NULL, 2);
+ content::NotificationService::AllSources(), 2);
// Bring up the bookmarks manager tab.
chrome::ShowBookmarkManager(browser());
Please sign in to comment.
Something went wrong with that request. Please try again.