Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Add darwinia-fee-market pallet #779

Merged
merged 77 commits into from Oct 18, 2021
Merged

Add darwinia-fee-market pallet #779

merged 77 commits into from Oct 18, 2021

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Aug 27, 2021

The darwinia-fee-market is implemented following Relayer Fee Market Design

Though there are some to-do tasks remain, I think his pr now is ready for review. One thing I want to note is that the parity-bridges-common dep branch is test-fee-market branch since this branch has some cherry-pick feature fee-market needed, the main branch doesn't have now. I am not so clear about how to deal with this branch, If the main branch can upgrade to contain the cherry-picked commit before we want to merge this pull request in, then we change to main as usual. If not, It's ok to me use a template cherry-pick branch now. But all of this doesn't influence the review of this pull request.

There are some remaining todo tasks:

  • Benchmark tests
  • Update type json file

@github-actions

This comment has been minimized.

@boundless-forest boundless-forest mentioned this pull request Sep 7, 2021
3 tasks
@robinwei-itering

This comment has been minimized.

@hackfisher hackfisher added this to In progress in Core Dev Kanban Sep 9, 2021
frame/fee-market/src/lib.rs Outdated Show resolved Hide resolved
frame/fee-market/src/lib.rs Show resolved Hide resolved
frame/fee-market/src/s2s/callbacks.rs Show resolved Hide resolved
frame/fee-market/src/s2s/payment.rs Show resolved Hide resolved
Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to avoid panic! in runtime, especially in hooks and extrinsic which could be called through scheduler's hook.

For other leaving questions, submitted to two new issues to track and fix in later pull requests:

#861
#862

@boundless-forest
Copy link
Member Author

@hackfisher @xiaoch05 @AurevoirXavier Please take a review again.

@hackfisher hackfisher merged commit f84630d into master Oct 18, 2021
Core Dev Kanban automation moved this from Review to Done Oct 18, 2021
@hackfisher hackfisher deleted the add-ask-price-pallet branch October 18, 2021 01:40
@AurevoirXavier
Copy link
Member

@sxlwar Types updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Relayer Fee market
5 participants