This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hackfisher
reviewed
Oct 13, 2021
hackfisher
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackfisher @xiaoch05 @AurevoirXavier Please take a review again. |
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
xiaoch05
reviewed
Oct 14, 2021
hackfisher
approved these changes
Oct 14, 2021
2 tasks
xiaoch05
approved these changes
Oct 15, 2021
@sxlwar Types updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
darwinia-fee-market
is implemented following Relayer Fee Market DesignThough there are some to-do tasks remain, I think his pr now is ready for review. One thing I want to note is that the parity-bridges-common dep branch is test-fee-market branch since this branch has some cherry-pick feature fee-market needed, the main branch doesn't have now. I am not so clear about how to deal with this branch, If the main branch can upgrade to contain the cherry-picked commit before we want to merge this pull request in, then we change to main as usual. If not, It's ok to me use a template cherry-pick branch now. But all of this doesn't influence the review of this pull request.
There are some remaining todo tasks: