New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error in qt/src/sugiyama.rs:752 #168

Closed
llogiq opened this Issue Jun 23, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@llogiq
Contributor

llogiq commented Jun 23, 2016

In the line (1,3) => a[0].1 != b[1].1 && b[0].1 == b[2].1 && a[0].1 == b[1].1,, the first and last subexpressions are a direct contradiction, the expression is thus always false (found by clippy).

Alas, I have no idea what the line means, so I submit this issue in the hope that someone who knows can fix it.

@flanfly flanfly added bug A-qml labels Jun 23, 2016

@flanfly

This comment has been minimized.

Show comment
Hide comment
@flanfly

flanfly Jun 23, 2016

Member

Hey @llogiq, thanks for the bug report. The function computes the number of edge crossings between two sets of nodes in the control flow graph in order to judge whenever the layout needs to be improved. I've long suspected that there is a bug because layouts never look completely "right". Could be that you found it. I'll look into it.

Member

flanfly commented Jun 23, 2016

Hey @llogiq, thanks for the bug report. The function computes the number of edge crossings between two sets of nodes in the control flow graph in order to judge whenever the layout needs to be improved. I've long suspected that there is a bug because layouts never look completely "right". Could be that you found it. I'll look into it.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Jun 24, 2016

Contributor

I didn't find it, clippy did 😄

Contributor

llogiq commented Jun 24, 2016

I didn't find it, clippy did 😄

@flanfly flanfly referenced this issue Jun 24, 2016

Merged

Fix #168 #169

@flanfly flanfly closed this in 968e218 Jun 24, 2016

flanfly added a commit that referenced this issue Jun 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment