Skip to content

Commit ed1cbd0

Browse files
irinaschubertsubotic
andauthored
chore(feature-toggles): remove remnants of feature toggles (DEV-217) (#2176)
* remove remnants of feature toggles * redo changes in PR template * refactor admin list routes * remove unused imports * fix formatting * refactor unnecessary companion objects in routes * fix codacy issues * fix codacy issues * Update expected-client-test-data.txt * add tests removed by accident Co-authored-by: Ivan Subotic <400790+subotic@users.noreply.github.com>
1 parent c30390f commit ed1cbd0

33 files changed

Lines changed: 1118 additions & 1512 deletions

‎docs/03-apis/api-v2/query-language.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,8 +1201,6 @@ The query performance of triplestores, such as Fuseki, is highly dependent on th
12011201
patterns. To improve performance, Gravsearch automatically reorders the
12021202
statement patterns in the WHERE clause according to their dependencies on each other, to minimise
12031203
the number of possible matches for each pattern.
1204-
This optimization can be controlled using `gravsearch-dependency-optimisation`
1205-
[feature toggle](../feature-toggles.md), which is turned on by default.
12061204

12071205
Consider the following Gravsearch query:
12081206

‎docs/03-apis/feature-toggles.md‎

Lines changed: 0 additions & 64 deletions
This file was deleted.

‎docs/03-apis/index.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,3 @@ The DSP APIs include:
1515
administering projects that use Knora as well as Knora itself.
1616
* The DSP [Util API](api-util/index.md), which is intended to be used for information retrieval
1717
about the DSP-stack itself.
18-
19-
DSP API v2 and the admin API support [Feature Toggles](feature-toggles.md).

‎docs/05-internals/design/principles/feature-toggles.md‎

Lines changed: 0 additions & 263 deletions
This file was deleted.

‎docs/05-internals/design/principles/index.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,3 @@
1313
- [Triplestore Updates](triplestore-updates.md)
1414
- [Consistency Checking](consistency-checking.md)
1515
- [Authentication](authentication.md)
16-
- [Feature Toggles](feature-toggles.md)

‎docs/05-internals/design/principles/rdf-api.md‎

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,9 @@
55

66
# RDF Processing API
77

8-
Knora provides an API for parsing and formatting RDF data and
9-
for working with RDF graphs. This allows Knora developers to use a single,
8+
DSP provides an API for parsing and formatting RDF data and
9+
for working with RDF graphs. This allows DSP developers to use a single,
1010
idiomatic Scala API as a façade for a Java RDF library.
11-
By using a feature toggle, you can choose either
12-
[Jena](https://jena.apache.org/tutorials/rdf_api.html)
13-
or
14-
[RDF4J](https://rdf4j.org/documentation/programming/)
15-
as the underlying implementation.
1611

1712

1813
## Overview
@@ -39,8 +34,8 @@ The API is in the package `org.knora.webapi.messages.util.rdf`. It includes:
3934
- `ShaclValidator`, which validates RDF models using SHACL shapes.
4035

4136
To work with RDF models, start with `RdfFeatureFactory`, which returns instances
42-
of `RdfNodeFactory`, `RdfModelFactory`, `RdfFormatUtil`, and `ShaclValidator`,
43-
using feature toggle configuration. `JsonLDUtil` does not need a feature factory.
37+
of `RdfNodeFactory`, `RdfModelFactory`, `RdfFormatUtil`, and `ShaclValidator`.
38+
`JsonLDUtil` does not need a feature factory.
4439

4540
To iterate efficiently over the statements in an `RdfModel`, use its `iterator` method.
4641
An `RdfModel` cannot be modified while you are iterating over it.
@@ -93,20 +88,6 @@ Turtle file containing the graph of shapes.
9388
- The RDF4J-based implementation, in package `org.knora.webapi.messages.util.rdf.rdf4jimpl`.
9489

9590

96-
## Feature toggle
97-
98-
For an overview of feature toggles, see [Feature Toggles](feature-toggles.md).
99-
100-
The RDF API uses the feature toggle `jena-rdf-library`:
101-
102-
- `on`: use the Jena implementation.
103-
104-
- `off` (the default): use the RDF4J implementation.
105-
106-
The default setting is used on startup, e.g. to read ontologies from the
107-
repository. After startup, the per-request setting is used.
108-
109-
11091
## TODO
11192

11293
- SHACL validation.

0 commit comments

Comments
 (0)