fix(webapi): unique username/email check on change user

[LukasStoeckli]

No description provided.

[subotic]

@LukasStoeckli what is the status of this PR?

[LukasStoeckli]

works, but:

• 'check if current email/username differs from the one in the change request' not in place, as I could not figure out how this nested conditions and exceptions stuff works
• stringFormatter.validate... from develop needs to be merged

[benjamingeer]

I haven't looked closely at this, but if you need to lock something to guarantee uniqueness of the values, you can use the Knora utility class IriLocker instead of Akka's Await.

[LukasStoeckli]

there is a global IRI lock. The point would be not to perform an update if the value hasn't changed. The issue is the scope of the conditions respectively the exceptions thrown in it. As in the code on develop, the exception is thrown but doesn't lead to not executing the rest of the function. As in this PR, everything works as intended, but there's no longer a check whether the new value is actually new.

[benjamingeer]

the exception is thrown but doesn't lead to not executing the rest of the function

I don't see how that's possible. Are you sure? is there a test for that?

[LukasStoeckli]

me neither. If you run these without the changes in UsersResponderADM, the values are 'successfully' updated.

[benjamingeer]

Is the failing ResourcesRouteV2E2E a common issue in the CI?

Yes, GraphDB often runs out of memory in GitHub CI, but we don't know why.

[benjamingeer]

ping

[benjamingeer]

@subotic Should we merge this PR?

[subotic]

@benjamingeer I guess so. The tests are passing.