fix(webapi): unique username/email check on change user #1561
Conversation
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Outdated
Show resolved
Hide resolved
@LukasStoeckli what is the status of this PR? |
works, but:
|
I haven't looked closely at this, but if you need to lock something to guarantee uniqueness of the values, you can use the Knora utility class |
there is a global IRI lock. The point would be not to perform an update if the value hasn't changed. The issue is the scope of the conditions respectively the exceptions thrown in it. As in the code on develop, the exception is thrown but doesn't lead to not executing the rest of the function. As in this PR, everything works as intended, but there's no longer a check whether the new value is actually new. |
I don't see how that's possible. Are you sure? is there a test for that? |
me neither. If you run these without the changes in UsersResponderADM, the values are 'successfully' updated. |
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Show resolved
Hide resolved
Yes, GraphDB often runs out of memory in GitHub CI, but we don't know why. |
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Outdated
Show resolved
Hide resolved
ping |
@subotic Should we merge this PR? |
@benjamingeer I guess so. The tests are passing. |
No description provided.