Skip to content

/ dsp-api

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clientapi): Change signature of function to update user's system admin membership #1583

Merged
merged 2 commits into from Feb 5, 2020
Merged

feat(clientapi): Change signature of function to update user's system admin membership #1583

merged 2 commits into from Feb 5, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Jan 24, 2020

This PR changes the signature of the client API function updateUserSystemAdminMembership as requested in #1579.

Resolves #1579.
@benjamingeer
feat(clientapi): Change method signature.
Loading status checks…
3e86a0a
@benjamingeer benjamingeer added this to the 2020-02 milestone Jan 24, 2020
@benjamingeer benjamingeer requested a review from tobiasschweizer Jan 24, 2020
@benjamingeer benjamingeer self-assigned this Jan 24, 2020
@benjamingeer benjamingeer mentioned this pull request Jan 24, 2020
Open
@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jan 27, 2020

Do you want me to make a PR in knora-api-js-lib that integrates this change?
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jan 27, 2020

Yes please
This was referenced Jan 27, 2020
Closed
Merged
@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jan 27, 2020

related PR: dasch-swiss/dsp-js-lib#138
@benjamingeer
Merge branch 'develop' into wip/1579-clientapi-sysadmin
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ce3ccc
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 4, 2020

@tobiasschweizer Is this OK to merge now?
@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Feb 4, 2020

I have my day off today, we can merge it tomorrow with dasch-swiss/dsp-js-lib#138.
@tobiasschweizer
tobiasschweizer approved these changes Feb 5, 2020
View changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Looks good. When you merge this PR, please also merge dasch-swiss/dsp-js-lib#138 (already approved by @kilchenmann).
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 5, 2020

Thanks @tobiasschweizer !
@benjamingeer benjamingeer merged commit c2a2559 into develop Feb 5, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
@benjamingeer benjamingeer deleted the wip/1579-clientapi-sysadmin branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer

Assignees

@benjamingeer benjamingeer

Labels
API/Admin clientapi
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Change signature of client method to update user's system admin membership
2 participants
@benjamingeer @tobiasschweizer