feat(clientapi): Change signature of function to update user's system admin membership #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingeer
added
API/Admin
clientapi
|
Do you want me to make a PR in knora-api-js-lib that integrates this change? |
|
Yes please |
This was referenced Jan 27, 2020
|
related PR: dasch-swiss/dsp-js-lib#138 |
|
@tobiasschweizer Is this OK to merge now? |
|
I have my day off today, we can merge it tomorrow with dasch-swiss/dsp-js-lib#138. |
tobiasschweizer
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Looks good. When you merge this PR, please also merge dasch-swiss/dsp-js-lib#138 (already approved by @kilchenmann).
|
Thanks @tobiasschweizer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of the client API function
updateUserSystemAdminMembershipas requested in #1579.Resolves #1579.