Skip to content

/ dsp-api

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-v2): Fix ontology deletion #1584

Merged
merged 2 commits into from Jan 28, 2020
Merged

fix(api-v2): Fix ontology deletion #1584

merged 2 commits into from Jan 28, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Jan 24, 2020 •
edited

This PR fixes ontology deletion so that the ontology is removed not only from the triplestore, but also from the ontology cache.

  • Fix incorrect test.
  • Fix ontology deletion in OntologyResponderV2.

Fixes #974.
@benjamingeer
test(api-v2): Fix test so it fails properly.
Loading status checks…
4c84580
@benjamingeer benjamingeer added the API/V2 label Jan 24, 2020
@benjamingeer benjamingeer added this to the 2020-02 milestone Jan 24, 2020
@benjamingeer benjamingeer self-assigned this Jan 24, 2020
@benjamingeer benjamingeer mentioned this pull request Jan 24, 2020
Open
@benjamingeer
fix(api-v2): Fix ontology deletion.
Loading status checks…
a2e4744
@benjamingeer benjamingeer requested a review from tobiasschweizer Jan 28, 2020
@tobiasschweizer tobiasschweizer requested review from lrosenth and kilchenmann Jan 28, 2020
@kilchenmann
kilchenmann approved these changes Jan 28, 2020
View changes
Copy link
Collaborator

@kilchenmann kilchenmann left a comment

Works fine for me. Thanks!
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jan 28, 2020

@kilchenmann Thanks for the review, and sorry for the bug! :)
@benjamingeer benjamingeer merged commit 70b0841 into develop Jan 28, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
@benjamingeer benjamingeer deleted the fix/974-delete-ontology branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann

@tobiasschweizer tobiasschweizer

@lrosenth lrosenth

Assignees

@benjamingeer benjamingeer

Labels
API/V2
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Deleting ontologies using API v2
2 participants
@benjamingeer @kilchenmann