Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-v2): Fix ontology deletion #1584

Merged
merged 2 commits into from Jan 28, 2020
Merged

fix(api-v2): Fix ontology deletion #1584

merged 2 commits into from Jan 28, 2020

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Jan 24, 2020 •
edited

This PR fixes ontology deletion so that the ontology is removed not only from the triplestore, but also from the ontology cache.

  • Fix incorrect test.
  • Fix ontology deletion in OntologyResponderV2.

Fixes #974.

@benjamingeer benjamingeer added this to the 2020-02 milestone Jan 24, 2020
@benjamingeer benjamingeer self-assigned this Jan 24, 2020
@benjamingeer benjamingeer mentioned this pull request Jan 24, 2020
Open
kilchenmann
kilchenmann approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Thanks!

@benjamingeer
Copy link
Author

@kilchenmann Thanks for the review, and sorry for the bug! :)

@benjamingeer benjamingeer merged commit 70b0841 into develop Jan 28, 2020
@benjamingeer benjamingeer deleted the fix/974-delete-ontology branch January 28, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilchenmann kilchenmann kilchenmann approved these changes

@tobiasschweizer tobiasschweizer Awaiting requested review from tobiasschweizer

@lrosenth lrosenth Awaiting requested review from lrosenth

Assignees

@benjamingeer benjamingeer

Labels
API/V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting ontologies using API v2
2 participants
@benjamingeer @kilchenmann