Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Remove client code generation #1610

Merged
merged 8 commits into from Feb 28, 2020
Merged

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Feb 25, 2020

  • Remove client code generation (leaving client test data generation).
  • Remove external schema of admin ontology.
  • Update docs.
  • Remove client test data dependency on incunabula.
  • Change JsonLDUtilSpec so it doesn't start an ActorSystem.

Resolves #1607.
Resolves #1600.

@benjamingeer benjamingeer added this to the 2020.1 milestone Feb 25, 2020
@benjamingeer benjamingeer self-assigned this Feb 25, 2020
@benjamingeer benjamingeer requested a review from tobiasschweizer Feb 26, 2020
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 26, 2020

@tobiasschweizer I don't know what needs to be changed in knora-api-js-lib for this, could you possibly help? I can probably do some of it if you can give me a list of things to do.

@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Feb 26, 2020

This PR will surely affect the way the generated test data is integrated into knora-api-js-lib.

The integration scripts for the admin part will have to be adapted (see also https://github.com/dasch-swiss/knora-api-js-lib/blob/master/package.json and https://github.com/dasch-swiss/knora-api-js-lib/blob/master/Makefile). Also E2E test for the admin part will have to be written. For now, there are only unit tests for the admin part.

I can help you with that, but only after my holiday. I will be back to work on Monday, 9 March.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 26, 2020

I can help you with that, but only after my holiday. I will be back to work on Monday, 9 March.

OK no problem, let's do it then.

@benjamingeer benjamingeer mentioned this pull request Feb 27, 2020
@benjamingeer benjamingeer requested a review from subotic Feb 27, 2020
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 27, 2020

@subotic The JS Lib Tests are failing, do you know what I would need to change to make them work again? Or does this need help from Tobias?

# Conflicts:
#	webapi/src/main/scala/org/knora/webapi/routing/v2/ValuesRouteV2.scala
#	webapi/src/main/scala/org/knora/webapi/util/StringFormatter.scala
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 28, 2020

@subotic Do you think this could be merged even though the JS Lib tests are failing? Then I wouldn't have to wait until Tobias gets back from holiday.

@subotic
Copy link
Collaborator

@subotic subotic commented Feb 28, 2020

Yeah sure.

Copy link
Collaborator

@subotic subotic left a comment

LGTM, thanks :-) I will take a look at knora-api-js-lib. Maybe I can fix it.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Feb 28, 2020

Thanks for the review!

@benjamingeer benjamingeer merged commit 6977ab3 into develop Feb 28, 2020
7 of 8 checks passed
7 of 8 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
JS Lib Tests JS Lib Tests
Details
Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
@benjamingeer benjamingeer deleted the wip/1607-client-code branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

3 participants