Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sipi makefile #1616

Merged
merged 1 commit into from Feb 28, 2020
Merged

fix: sipi makefile #1616

merged 1 commit into from Feb 28, 2020

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented Feb 28, 2020

resolves #1614

@subotic subotic self-assigned this Feb 28, 2020
@subotic subotic requested a review from benjamingeer Feb 28, 2020
@subotic
Copy link
Collaborator Author

@subotic subotic commented Feb 28, 2020

@benjamingeer sorry, this should fix the issue with sipi.

Copy link
Collaborator

@benjamingeer benjamingeer left a comment

Thanks, could you also add something to knora-api/sipi/README.md to say that you have to set SIPI_VERSION and to indicate what it could be set to?

Copy link
Collaborator

@benjamingeer benjamingeer left a comment

The Makefile still doesn't work for me:

% cd git/knora-api/sipi
% echo $SIPI_VERSION
2.0.1
% make up
docker-compose up -d sipi
Pulling sipi (dhlabbasel/sipi:2.0.1)...
ERROR: manifest for dhlabbasel/sipi:2.0.1 not found: manifest unknown: manifest unknown
make: *** [up] Error 1
Copy link
Collaborator

@benjamingeer benjamingeer left a comment

Works now after removing the SIPI_VERSION environment variable I had set, thanks!

@subotic subotic merged commit 73a0afe into develop Feb 28, 2020
8 checks passed
8 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
JS Lib Tests
Details
Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
@subotic subotic deleted the wip/1614-fix-sipi branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants