Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OntologyResponderV2): Add a global ontology cache lock #1637

Merged
merged 4 commits into from Apr 27, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Apr 22, 2020

@benjamingeer benjamingeer requested a review from lrosenth Apr 22, 2020
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Apr 22, 2020

@lrosenth Please try this branch. There was already an update lock on each ontology, but that doesn't help if you have concurrent updates to different ontologies, so I used a global update lock instead. See if this fixes the problem.

@benjamingeer benjamingeer requested a review from subotic Apr 25, 2020
Copy link
Collaborator

@subotic subotic left a comment

Great, thanks! LGTM :-)

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Apr 27, 2020

@subotic Thanks for the review!

@benjamingeer benjamingeer merged commit 1853865 into develop Apr 27, 2020
9 checks passed
9 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
JS Lib Tests (11.x)
Details
Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish to Dockerhub
Details
@benjamingeer benjamingeer deleted the fix/DSP-181-ontology-updates branch Apr 27, 2020
@benjamingeer benjamingeer mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants