Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete functions from StringFormatter #1640

Merged
merged 3 commits into from May 4, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Apr 27, 2020

This PR removes some obsolete functions that I forgot to remove a long time ago.

User story:

https://dasch.myjetbrains.com/youtrack/issue/DSP-130

@benjamingeer benjamingeer requested a review from subotic Apr 27, 2020
@benjamingeer benjamingeer self-assigned this Apr 27, 2020
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented May 4, 2020

@subotic ping

@subotic
subotic approved these changes May 4, 2020
Copy link
Collaborator

@subotic subotic left a comment

Great :-) LGTM

@subotic
Copy link
Collaborator

@subotic subotic commented May 4, 2020

Sorry, didn't see that I should review it. Maybe we could try adding the reviewer as a second assignee on YT when moving the ticket to "To Review"? I'm relatively frequently scanning the Agile Boards on YouTrack for my picture :-)

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented May 4, 2020

@subotic Sorry for asking you to review this very long PR. :)

@benjamingeer benjamingeer merged commit 5fa6de4 into develop May 4, 2020
9 checks passed
9 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
JS Lib Tests (12.x)
Details
Upgrade Unit Tests Upgrade Unit Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish to Dockerhub
Details
@benjamingeer benjamingeer deleted the wip/DSP-130-string-formatter branch May 4, 2020
@benjamingeer benjamingeer mentioned this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants