Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gravsearch): Remove deprecated functions #1660

Merged
merged 5 commits into from Jun 28, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Jun 19, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-417

This PR removes support for deprecated Gravsearch functions that can't be supported with Apache Jena Fuseki:

  • knora-api:match
  • knora-api:matchInStandoff

These have already been replaced with:

  • knora-api:matchText
  • knora-api:matchTextInStandoff
@benjamingeer benjamingeer self-assigned this Jun 19, 2020
@benjamingeer benjamingeer requested review from subotic and tobiasschweizer Jun 19, 2020
@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jun 22, 2020

@benjamingeer Which RC is going to contain these changes?

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jun 22, 2020

Hopefully in v13.0.0-rc.6?

@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jun 22, 2020

Hopefully in v13.0.0-rc.6?

I have to refactor the Gravsearch generation in the UI anyway and I am already working on it, so that's not a problem.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jun 22, 2020

I have to refactor the Gravsearch generation in the UI anyway and I am already working on it, so that's not a problem.

OK great.

@tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jun 23, 2020

@benjamingeer Is it ok when I do the review on Thursday?

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jun 23, 2020

@tobiasschweizer No problem!

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Do I understand correctly that matchText works the same in both the simple and complex schema? With the deprecated function match, in the complex schema you had to get the string literal from the TextValue.

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

I think I could answer my question myself by looking at the tests you changed :-)

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jun 25, 2020

Yes, sorry, the answer is yes. :)

Copy link
Collaborator

@subotic subotic left a comment

LGTM, thanks :-)

@benjamingeer benjamingeer merged commit 5d3af46 into develop Jun 28, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish to Dockerhub (on release only)
Details
@benjamingeer benjamingeer deleted the wip/DSP-417-deprecated-functions branch Jun 28, 2020
@subotic subotic added the enhancement label Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants