Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init db scripts (DSP-511) #1681

merged 3 commits into from Jul 23, 2020


Copy link

@subotic subotic commented Jul 22, 2020

No description provided.

Copy link
Collaborator Author

subotic commented Jul 22, 2020

@SepidehAlassi I've also pushed the fix to the readme. After merging this. We should make a new knora-api release.

Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix. Please just correct the minor typo as it might confuse the first time users. Outdated Show resolved Hide resolved
Copy link
Collaborator Author

subotic commented Jul 22, 2020

@SepidehAlassi Thanks for the review 😀

@subotic subotic changed the title fix: init db scripts fix: init db scripts (DSP-511) Jul 23, 2020
@subotic subotic merged commit d4505ce into develop Jul 23, 2020
@subotic subotic deleted the wip/DSP-511-fix-init-db-test-and-friends branch July 23, 2020 04:42
@subotic subotic added the bug something isn't working label Jul 23, 2020
@subotic subotic self-assigned this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants