Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init db scripts (DSP-511) #1681

Merged
merged 3 commits into from Jul 23, 2020
Merged

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented Jul 22, 2020

No description provided.

@subotic subotic requested a review from SepidehAlassi Jul 22, 2020
@subotic
Copy link
Collaborator Author

@subotic subotic commented Jul 22, 2020

@SepidehAlassi I've also pushed the fix to the readme. After merging this. We should make a new knora-api release.

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

LGTM, thanks for the quick fix. Please just correct the minor typo as it might confuse the first time users.

README.md Outdated Show resolved Hide resolved
@subotic
Copy link
Collaborator Author

@subotic subotic commented Jul 22, 2020

@SepidehAlassi Thanks for the review 😀

@subotic subotic changed the title fix: init db scripts fix: init db scripts (DSP-511) Jul 23, 2020
@subotic subotic merged commit d4505ce into develop Jul 23, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
@subotic subotic deleted the wip/DSP-511-fix-init-db-test-and-friends branch Jul 23, 2020
@subotic subotic added the bug label Jul 23, 2020
@subotic subotic self-assigned this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants