Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server header (DSP-537) #1691

Merged
merged 4 commits into from Aug 18, 2020
Merged

fix: server header (DSP-537) #1691

merged 4 commits into from Aug 18, 2020

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented Aug 16, 2020

  • add test to check server header for expected structure
  • fix returned server header
@subotic subotic self-assigned this Aug 16, 2020
@subotic subotic added the bug label Aug 16, 2020
subotic added 2 commits Aug 17, 2020
@subotic subotic marked this pull request as ready for review Aug 18, 2020
@subotic subotic requested a review from SepidehAlassi Aug 18, 2020
@@ -43,8 +43,15 @@ class ServerVersionE2ESpec extends E2ESpec(ServerVersionE2ESpec.config) {
"return the custom 'Server' header with every response" in {
val request = Get(baseApiUrl + s"/admin/projects")
val response: HttpResponse = singleAwaitingRequest(request)
// logger.debug(s"response: ${response.toString}")
println(s"response: ${response.toString}")
logger.debug(s"response: ${response.toString}")

This comment has been minimized.

@SepidehAlassi

SepidehAlassi Aug 18, 2020
Contributor

Please remove the println and logger.debug.
Hint: You can easily use the InteliJ debugger for checking the values.

This comment has been minimized.

@subotic

subotic Aug 18, 2020
Author Collaborator

Please remove the println and logger.debug.
Hint: You can easily use the InteliJ debugger for checking the values.

done and breakpoints are working :-)

@subotic subotic merged commit 8d7bee8 into develop Aug 18, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
@subotic subotic deleted the wip/DSP-537-server-header branch Aug 18, 2020
@subotic
Copy link
Collaborator Author

@subotic subotic commented Aug 18, 2020

Thanks for the review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants