Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Fix generated SPARQL for updating property comment #1693

Merged
merged 2 commits into from Aug 24, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Aug 24, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-561

  • In the WHERE clause of changePropertyLabelsOrComments.scala.txt, move BIND statements inside the GRAPH block, so that the WHERE clause will return results even if the property doesn't have an rdfs:comment. TODO: ask the Jena developers why this makes a difference.
  • Fix a bug in OntologyResponderV2.changePropertyLabelsOrComments which would incorrectly compare a saved link value property with the expected result.
  • Add a test for adding an rdfs:comment to a link property that doesn't have one.
@benjamingeer benjamingeer requested a review from SepidehAlassi Aug 24, 2020
@benjamingeer benjamingeer self-assigned this Aug 24, 2020
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Thanks for the quick fix!

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Aug 24, 2020

Thanks for the quick review. :)

@benjamingeer benjamingeer merged commit 7b70339 into develop Aug 24, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
@benjamingeer benjamingeer deleted the fix/DSP-561-property-update branch Aug 24, 2020
@subotic subotic added the bug label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants