Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Fix generated SPARQL for updating property comment #1693

merged 2 commits into from Aug 24, 2020


Copy link

@benjamingeer benjamingeer commented Aug 24, 2020

  • In the WHERE clause of changePropertyLabelsOrComments.scala.txt, move BIND statements inside the GRAPH block, so that the WHERE clause will return results even if the property doesn't have an rdfs:comment. TODO: ask the Jena developers why this makes a difference.
  • Fix a bug in OntologyResponderV2.changePropertyLabelsOrComments which would incorrectly compare a saved link value property with the expected result.
  • Add a test for adding an rdfs:comment to a link property that doesn't have one.

Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link

Thanks for the quick review. :)

@benjamingeer benjamingeer merged commit 7b70339 into develop Aug 24, 2020
@benjamingeer benjamingeer deleted the fix/DSP-561-property-update branch August 24, 2020 10:59
@subotic subotic added the bug something isn't working label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants