Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix publishing #1694

Merged
merged 2 commits into from Sep 3, 2020
Merged

docs: fix publishing #1694

merged 2 commits into from Sep 3, 2020

Conversation

@RalfBarkow
Copy link
Contributor

@RalfBarkow RalfBarkow commented Aug 24, 2020

Fix make targets docker-build and docker-publish
Fix Dockerhub Organization name and link.

Fix Dockerhub Organization name and link.
@subotic
Copy link
Collaborator

@subotic subotic commented Aug 24, 2020

Thanks for the fixes.

@subotic
Copy link
Collaborator

@subotic subotic commented Aug 24, 2020

@benjamingeer here we have the same problem, as in the other PR. Github-CI is not running for PRs coming from outside of our organization.

@RalfBarkow
Copy link
Contributor Author

@RalfBarkow RalfBarkow commented Aug 24, 2020

@benjamingeer […] Github-CI is not running for PRs coming from outside of our organization

Just found this thread in the GitHub Support Community linking to Chris Patterson's blog post GitHub Actions improvements for fork and pull request workflows (August 3, 2020).

See Improvements for public repository forks: they’ve added a new pull_request_target event.

@subotic
Copy link
Collaborator

@subotic subotic commented Aug 24, 2020

Thanks for the link.

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Sep 3, 2020

@subotic Do you know if there's some way we can merge this and #1688?

@subotic
Copy link
Collaborator

@subotic subotic commented Sep 3, 2020

@benjamingeer We could allow admins to merge despite the tests not running. In this case, this should be ok.

@subotic subotic self-requested a review Sep 3, 2020
@subotic
subotic approved these changes Sep 3, 2020
Copy link
Collaborator

@subotic subotic left a comment

Thanks! LGTM.

@subotic subotic changed the title Knora Documentation > Publishing and Deployment docs: fix publishing Sep 3, 2020
@subotic subotic merged commit d06b6a6 into dasch-swiss:develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants