Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api-v2): Switch from JSONLD-Java to Titanium #1715

Merged
merged 4 commits into from Sep 24, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Sep 23, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-458

  • Change Bazel dependencies.
  • Change JsonLDUtil to use titanium-json-ld instead of JSONLD-JAVA.
  • Remove functionality in JavaUtil that was used only with JSONLD-JAVA.
  • Remove unused method in AkkaHttpUtils that depended on JSONLD-JAVA.
  • Change JSONLDHandlingV2R2RSpec to use spray-json instead of JSONLD-JAVA.
  • Fix a bug in CreateMappingResponseV2 that Titanium found.
  • Fix tests so they don't depend on whitespace in pretty-printed JSON.
  • Update JSON-LD design doc.
@benjamingeer benjamingeer self-assigned this Sep 23, 2020
@benjamingeer benjamingeer changed the title refactor(api-v2): Switch from JSONLD-Java to Titanium chore(api-v2): Switch from JSONLD-Java to Titanium Sep 23, 2020
@benjamingeer benjamingeer marked this pull request as draft Sep 23, 2020
@benjamingeer benjamingeer marked this pull request as ready for review Sep 23, 2020
@benjamingeer benjamingeer requested a review from SepidehAlassi Sep 23, 2020
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Looks great! Thank you.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Sep 24, 2020

Thanks for the review!

@benjamingeer benjamingeer merged commit 9e28e5b into develop Sep 24, 2020
7 checks passed
7 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
@benjamingeer benjamingeer deleted the wip/DSP-458-titanium branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants