Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v1): Change API v1 file uploads to work like API v2 (DSP-41, PR 3) #1722

merged 9 commits into from Oct 6, 2020


Copy link

@benjamingeer benjamingeer commented Sep 30, 2020

This PR changes API v1 so that Knora and Sipi no longer need to share a filesystem.

  • Port #1667 to the current code structure:
    • Change API v1 to use the same Sipi scripts as API v2.
    • Remove the API v1 Sipi scripts.
    • Change salsah1 to use upload.lua, sending it a JWT token.
    • Update other API v1 tests.
    • Update API v1 docs.
  • Add necessary support for text files in API v1.
  • Update KnoraSipiIntegrationV1ITSpec to create XSLTransformation resources using upload.lua.

Breaking API v1 change: To enable Knora and Sipi to work without sharing a filesystem, the procedure for uploading files in API v1 has changed; see docs/03-apis/api-v1/, sections "Adding Resources with Image Files" and "Bulk Import with Image Files".

Moved from #1667.
Resolves #535.
Resolves DSP-41.
Resolves DSP-42.

@benjamingeer benjamingeer marked this pull request as draft Sep 30, 2020
@benjamingeer benjamingeer self-assigned this Oct 1, 2020
@benjamingeer benjamingeer requested a review from subotic Oct 1, 2020
@benjamingeer benjamingeer marked this pull request as ready for review Oct 1, 2020
subotic approved these changes Oct 6, 2020
Copy link

@subotic subotic left a comment

Thanks, LGTM!

Copy link
Collaborator Author

@benjamingeer benjamingeer commented Oct 6, 2020

Thank you for the review! So glad to see this finally done.
🎉 🥳

@benjamingeer benjamingeer merged commit a824bcc into develop Oct 6, 2020
8 checks passed
8 checks passed
Build Everything Build Everything
API Unit Tests API Unit Tests
API E2E Tests API E2E Tests
API Integration Tests API Integration Tests
Upgrade Integration Tests Upgrade Integration Tests
Docs Build Test
Update next release draft
Publish (on release only)
@benjamingeer benjamingeer deleted the wip/DSP-42-api-v1-file-upload branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants