Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): Update ScalaTest (DSP-919) #1745

Merged
merged 4 commits into from Oct 29, 2020
Merged

chore(build): Update ScalaTest (DSP-919) #1745

merged 4 commits into from Oct 29, 2020

Conversation

benjamingeer
Copy link

May resolve DSP-919.

@benjamingeer benjamingeer added the chore maintenance and build tasks label Oct 28, 2020
@benjamingeer benjamingeer self-assigned this Oct 28, 2020
subotic
subotic approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for doing it. It seems to work. LGTM!

@benjamingeer
Copy link
Author

Thanks for the review, let's see if it works on the develop branch. :)

@benjamingeer benjamingeer merged commit bbaeadd into develop Oct 29, 2020
@benjamingeer benjamingeer deleted the fix/DSP-919-test-failures branch October 29, 2020 09:10
@subotic subotic added dependencies Pull requests that update a dependency file (with fuseki, sipi, etc.) and removed chore maintenance and build tasks labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@benjamingeer benjamingeer

Labels
dependencies Pull requests that update a dependency file (with fuseki, sipi, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benjamingeer @subotic