Skip to content

/ dsp-api

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): Update ScalaTest (DSP-919) #1745

Merged
merged 4 commits into from Oct 29, 2020
Merged

chore(build): Update ScalaTest (DSP-919) #1745

merged 4 commits into from Oct 29, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Oct 28, 2020

May resolve DSP-919.
@benjamingeer
chore(build): Update ScalaTest.
Loading status checks…
ef8858f
@benjamingeer benjamingeer added the chore label Oct 28, 2020
@benjamingeer benjamingeer self-assigned this Oct 28, 2020
@benjamingeer
fix(build): Add missing deps.
Loading status checks…
7acf6a9
@benjamingeer
Merge branch 'develop' into fix/DSP-919-test-failures
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a351480
@benjamingeer benjamingeer requested a review from subotic Oct 28, 2020
@subotic
subotic approved these changes Oct 28, 2020
View changes
Copy link
Collaborator

@subotic subotic left a comment

Cool, thanks for doing it. It seems to work. LGTM!
@benjamingeer
Merge branch 'develop' into fix/DSP-919-test-failures
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c11f8b
@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Oct 29, 2020

Thanks for the review, let's see if it works on the develop branch. :)
@benjamingeer benjamingeer merged commit bbaeadd into develop Oct 29, 2020
8 checks passed
8 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Update next release draft
Details
Publish (on release only)
Details
@benjamingeer benjamingeer deleted the fix/DSP-919-test-failures branch Oct 29, 2020
@subotic subotic added dependencies and removed chore labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic

Assignees

@benjamingeer benjamingeer

Labels
dependencies
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benjamingeer @subotic