Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-1029: Add the missing dependency #1755

Merged
merged 1 commit into from Nov 9, 2020
Merged

DSP-1029: Add the missing dependency #1755

merged 1 commit into from Nov 9, 2020

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Nov 9, 2020

resolves DSP-1029

@SepidehAlassi SepidehAlassi added the bug label Nov 9, 2020
@SepidehAlassi SepidehAlassi self-assigned this Nov 9, 2020
@SepidehAlassi SepidehAlassi requested a review from benjamingeer Nov 9, 2020
Copy link
Collaborator

@benjamingeer benjamingeer left a comment

Thank you!

@SepidehAlassi SepidehAlassi changed the title Add the missing dependency DSP-1029: Add the missing dependency Nov 9, 2020
@SepidehAlassi SepidehAlassi merged commit 0e37d21 into main Nov 9, 2020
8 checks passed
8 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Update next release draft
Details
Publish (on release only)
Details
@SepidehAlassi SepidehAlassi deleted the fix/dependencies branch Nov 9, 2020
@subotic
Copy link
Collaborator

@subotic subotic commented Nov 9, 2020

@SepidehAlassi Bazel complains only about not needed compile time dependencies. This seems to me to be a runtime dependency, which has to be added to the correct property. Please make this correction in one of your future PRs or it is just a matter of time until it will happen again. I don't delete dependencies by hand, instead I use the buildozer tool and this tool doesn't know how to read (comments) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants