Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Control JSON-LD nesting via an HTTP header (DSP-1084) #1758

merged 5 commits into from Nov 18, 2020


Copy link

@benjamingeer benjamingeer commented Nov 17, 2020

  • Optionally build a flat JsonLDDocument when converting from an RdfModel.
  • Optionally flatten an existing JsonLDDocument.
  • Choose hierarchical or flat JSON-LD via an HTTP header.
  • Add docs.

resolves DSP-1084.

@benjamingeer benjamingeer added enhancement improve existing code or new feature API/V2 labels Nov 17, 2020
@benjamingeer benjamingeer self-assigned this Nov 17, 2020
@benjamingeer benjamingeer removed the request for review from SepidehAlassi November 17, 2020 19:31
@benjamingeer benjamingeer marked this pull request as draft November 17, 2020 19:31
@benjamingeer benjamingeer marked this pull request as ready for review November 18, 2020 13:09
Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for implementing it!

Copy link

Thanks for the review!

@benjamingeer benjamingeer merged commit b13eecf into main Nov 18, 2020
@benjamingeer benjamingeer deleted the wip/DSP-1084-JSON-LD branch November 18, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
API/V2 enhancement improve existing code or new feature
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants