Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Control JSON-LD nesting via an HTTP header (DSP-1084) #1758

Merged
merged 5 commits into from Nov 18, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Nov 17, 2020

  • Optionally build a flat JsonLDDocument when converting from an RdfModel.
  • Optionally flatten an existing JsonLDDocument.
  • Choose hierarchical or flat JSON-LD via an HTTP header.
  • Add docs.

resolves DSP-1084.

@benjamingeer benjamingeer requested a review from SepidehAlassi Nov 17, 2020
@benjamingeer benjamingeer removed the request for review from SepidehAlassi Nov 17, 2020
@benjamingeer benjamingeer marked this pull request as draft Nov 17, 2020
@benjamingeer benjamingeer marked this pull request as ready for review Nov 18, 2020
@benjamingeer benjamingeer requested a review from SepidehAlassi Nov 18, 2020
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This looks great, thanks for implementing it!

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Nov 18, 2020

Thanks for the review!

@benjamingeer benjamingeer merged commit b13eecf into main Nov 18, 2020
8 checks passed
8 checks passed
Build Everything Build Everything
Details
API Unit Tests API Unit Tests
Details
API E2E Tests API E2E Tests
Details
API Integration Tests API Integration Tests
Details
Upgrade Integration Tests Upgrade Integration Tests
Details
Docs Build Test Docs Build Test
Details
Update next release draft
Details
Publish (on release only)
Details
@benjamingeer benjamingeer deleted the wip/DSP-1084-JSON-LD branch Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants