Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rdf-api): Use the Jena RDF API implementation by default (DSP-1153) #1772

Merged
merged 4 commits into from Dec 10, 2020

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Dec 8, 2020

resolves DSP-1153

  • Set feature toggle jena-rdf-library to be on by default.
  • Fix SPARQL in tests to use named graphs correctly with Jena.
    • Document why.
  • Fix the string representation of datatype values in SPARQL query results from an in-memory repository.
    • Check that in a test.
@benjamingeer benjamingeer self-assigned this Dec 8, 2020
@benjamingeer benjamingeer added the chore label Dec 8, 2020
@benjamingeer benjamingeer requested review from SepidehAlassi and removed request for SepidehAlassi Dec 8, 2020
@benjamingeer benjamingeer marked this pull request as draft Dec 8, 2020
…ion.

- Don't return datatypes in SPARQL query results.
@benjamingeer benjamingeer marked this pull request as ready for review Dec 9, 2020
@benjamingeer benjamingeer requested a review from SepidehAlassi Dec 9, 2020
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This looks good, thanks!

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Dec 10, 2020

Thanks for reviewing!

@benjamingeer benjamingeer merged commit 389feb4 into main Dec 10, 2020
8 checks passed
8 checks passed
Build Everything
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Update next release draft
Details
Publish (on release only)
Details
@benjamingeer benjamingeer deleted the wip/DSP-1153-rdf-api branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants