Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rdf-api): Use the Jena RDF API implementation by default (DSP-1153) #1772

merged 4 commits into from Dec 10, 2020


Copy link

@benjamingeer benjamingeer commented Dec 8, 2020

resolves DSP-1153

  • Set feature toggle jena-rdf-library to be on by default.
  • Fix SPARQL in tests to use named graphs correctly with Jena.
    • Document why.
  • Fix the string representation of datatype values in SPARQL query results from an in-memory repository.
    • Check that in a test.

@benjamingeer benjamingeer self-assigned this Dec 8, 2020
@benjamingeer benjamingeer added the chore maintenance and build tasks label Dec 8, 2020
@benjamingeer benjamingeer requested review from SepidehAlassi and removed request for SepidehAlassi December 8, 2020 17:10
@benjamingeer benjamingeer marked this pull request as draft December 8, 2020 20:52

- Don't return datatypes in SPARQL query results.
@benjamingeer benjamingeer marked this pull request as ready for review December 9, 2020 11:48
Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

Copy link

Thanks for reviewing!

@benjamingeer benjamingeer merged commit 389feb4 into main Dec 10, 2020
@benjamingeer benjamingeer deleted the wip/DSP-1153-rdf-api branch December 10, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
chore maintenance and build tasks
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants