Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Generate IIIF manifest (DSP-50) #1784

Merged
merged 18 commits into from May 17, 2021
Merged

Conversation

@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented Jan 14, 2021

resolves DSP-50

@benjamingeer benjamingeer requested a review from SepidehAlassi May 6, 2021
@benjamingeer benjamingeer marked this pull request as ready for review May 6, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Can you please add a test for the structure of the returned manifest?


for {
// Make a Gravsearch query from a template.
gravsearchQuery: String <- Future(

This comment has been minimized.

@SepidehAlassi

SepidehAlassi May 10, 2021
Contributor

please rename this to something likequeryForIncomingLinks.

@benjamingeer
Copy link
Contributor Author

@benjamingeer benjamingeer commented May 17, 2021

@SepidehAlassi Is this OK now?

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This is great, thanks for all your work.

@benjamingeer
Copy link
Contributor Author

@benjamingeer benjamingeer commented May 17, 2021

Thanks for reviewing!

@benjamingeer benjamingeer merged commit 74feb2c into main May 17, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the wip/DSP-50-iiif-manifest-2 branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants