Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): Delete permissions: (DSP-1169) #1787

Merged
merged 13 commits into from Jan 27, 2021

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Jan 15, 2021

resolves DSP-1169
Additionally:

  • For all permission operations systematically check requesting user's permission for the operation + tests
@SepidehAlassi SepidehAlassi marked this pull request as ready for review Jan 15, 2021
@SepidehAlassi SepidehAlassi requested review from benjamingeer and subotic Jan 15, 2021
@SepidehAlassi SepidehAlassi requested a review from subotic Jan 25, 2021
Copy link
Collaborator

@subotic subotic left a comment

Awesome, thanks :-)

@SepidehAlassi
Copy link
Contributor Author

@SepidehAlassi SepidehAlassi commented Jan 27, 2021

@subotic Thanks for reviewing this!

@SepidehAlassi SepidehAlassi merged commit 3fe8c14 into main Jan 27, 2021
10 checks passed
10 checks passed
Build Everything
Details
Prepare next release
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1169-DeletePermissions branch Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants