Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Don't allow an invalid cardinality on a boolean property (DSP-1236) #1788

merged 3 commits into from Jan 21, 2021


Copy link

@benjamingeer benjamingeer commented Jan 18, 2021

resolves DSP-1236

  • Don't allow adding an invalid cardinality on a boolean property.
  • Allow startup even if ontologies are invalid.
  • Add test.

@benjamingeer benjamingeer added bug something isn't working API/V2 labels Jan 18, 2021
@benjamingeer benjamingeer self-assigned this Jan 18, 2021
Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for fixing the bug.

Copy link

Thanks for the review!

@benjamingeer benjamingeer merged commit 3d5f802 into main Jan 21, 2021
@benjamingeer benjamingeer deleted the fix/DSP-1236-boolean-cardinality branch January 21, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
API/V2 bug something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants