Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Don't allow an invalid cardinality on a boolean property (DSP-1236) #1788

Merged
merged 3 commits into from Jan 21, 2021

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Jan 18, 2021

resolves DSP-1236

  • Don't allow adding an invalid cardinality on a boolean property.
  • Allow startup even if ontologies are invalid.
  • Add test.
@benjamingeer benjamingeer self-assigned this Jan 18, 2021
@benjamingeer benjamingeer requested a review from SepidehAlassi Jan 18, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This looks great, thanks for fixing the bug.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Jan 21, 2021

Thanks for the review!

@benjamingeer benjamingeer merged commit 3d5f802 into main Jan 21, 2021
10 checks passed
10 checks passed
Build Everything
Details
Prepare next release
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the fix/DSP-1236-boolean-cardinality branch Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants