Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v1): Add support for PDF files (DSP-1267) #1797

Merged
merged 19 commits into from Feb 3, 2021

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Jan 26, 2021

resolves DSP-1267

@benjamingeer benjamingeer self-assigned this Jan 26, 2021
@benjamingeer benjamingeer marked this pull request as draft Jan 26, 2021
benjamingeer and others added 13 commits Jan 27, 2021
# Conflicts:
#	webapi/src/main/scala/org/knora/webapi/messages/v1/responder/valuemessages/ValueMessagesV1.scala
@benjamingeer benjamingeer requested a review from SepidehAlassi Feb 2, 2021
@benjamingeer benjamingeer marked this pull request as ready for review Feb 2, 2021
benjamingeer added 5 commits Feb 2, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This looks good, thanks!

@benjamingeer benjamingeer merged commit c3b2e84 into main Feb 3, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the wip/DSP-1267-api-v1-pdf branch Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants