Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sipi): add storing of original and sidecar (DSP-1318) #1808

merged 8 commits into from Feb 5, 2021


Copy link

@lrosenth lrosenth commented Feb 1, 2021

resolves DSP-1318. The changed lua scripts now preserve the original uploaded file and create a sidecar file that contains the original filename, derivative filename and SHA256-checksums.

In SIPI "knora.json" has been changed to read the sidecar file if available and return also the original filename for non-image files. This the original filename can be preserved on the dsp-api backend

DSP-API now returns a URL ending in /file as the object of knora-api:fileValueAsUrl for non-image files.

@lrosenth lrosenth added the enhancement improve existing code or new feature label Feb 1, 2021
@lrosenth lrosenth self-assigned this Feb 1, 2021
@subotic subotic changed the title Wip/dsp 1318 lua original and sidecar feat(sipi): add storing of original and sidecar (DSP-1318) Feb 2, 2021
Copy link

subotic commented Feb 4, 2021

@benjamingeer I've updated the Sipi version.

Copy link

subotic commented Feb 5, 2021

@benjamingeer would you maybe have a bit of time today to work on this PR?

Copy link

@subotic I've been working on it this morning, it's almost done.

Benjamin Geer added 2 commits February 5, 2021 09:23
# Conflicts:
#	webapi/src/main/scala/org/knora/webapi/messages/util/ValueUtilV1.scala
#	webapi/src/main/scala/org/knora/webapi/messages/v1/responder/valuemessages/ValueMessagesV1.scala
#	webapi/src/main/scala/org/knora/webapi/responders/v1/ResourcesResponderV1.scala
Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, I think this is good to merge now.

@benjamingeer benjamingeer merged commit 022ed7e into main Feb 5, 2021
@benjamingeer benjamingeer deleted the wip/DSP-1318-lua-original-and-sidecar branch February 5, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement improve existing code or new feature
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants