feat(sipi): add storing of original and sidecar (DSP-1318) #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subotic
changed the title
|
@benjamingeer I've updated the Sipi version. |
|
@benjamingeer would you maybe have a bit of time today to work on this PR? |
|
@subotic I've been working on it this morning, it's almost done. |
added 2 commits
February 5, 2021 09:23
# Conflicts: # webapi/src/main/scala/org/knora/webapi/messages/util/ValueUtilV1.scala # webapi/src/main/scala/org/knora/webapi/messages/v1/responder/valuemessages/ValueMessagesV1.scala # webapi/src/main/scala/org/knora/webapi/responders/v1/ResourcesResponderV1.scala
benjamingeer
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1318. The changed lua scripts now preserve the original uploaded file and create a sidecar file that contains the original filename, derivative filename and SHA256-checksums.
In SIPI "knora.json" has been changed to read the sidecar file if available and return also the original filename for non-image files. This the original filename can be preserved on the dsp-api backend
DSP-API now returns a URL ending in
/fileas the object ofknora-api:fileValueAsUrlfor non-image files.