Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make targets for adding metadata (DSP-1289) #1810

Merged
merged 8 commits into from Feb 4, 2021

Conversation

@BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Feb 3, 2021

Resolves DSP-1289

@BalduinLandolt BalduinLandolt self-assigned this Feb 3, 2021
@mpro7
Copy link
Contributor

@mpro7 mpro7 commented Feb 3, 2021

Thanks @BalduinLandolt, I add my 2 Rappens here instead MD channel.

I think stack-down-delete-volumes is obsolete, because init-db-test is covering it.

I would also not include into make metadata command others than these related to metadata, because most of the time at least init-db-test would be obsolete here too. IMO into make metadata I would include just make stack-up and all possible dataset to be loaded.

@BalduinLandolt
Copy link
Contributor Author

@BalduinLandolt BalduinLandolt commented Feb 3, 2021

@mpro7 thanks for your input!

Sadly, we can only ever have one metadata set at once, since I'm loading them into the same project, otherwise they would just overwrite one another.
But yes, I'll change it right away.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review Feb 3, 2021
@BalduinLandolt BalduinLandolt requested review from mpro7 and subotic Feb 3, 2021
@mpro7
mpro7 approved these changes Feb 4, 2021
Copy link
Contributor

@mpro7 mpro7 left a comment

This is it, thanks!

@BalduinLandolt BalduinLandolt requested a review from mpro7 Feb 4, 2021
@BalduinLandolt
Copy link
Contributor Author

@BalduinLandolt BalduinLandolt commented Feb 4, 2021

@mpro7 I moved the metadata stuff to a separate stack-up-with-metadata target. @subotic did not want me to clutter stack-up even more. Does this still seem useful to you?

@mpro7
mpro7 approved these changes Feb 4, 2021
Copy link
Contributor

@mpro7 mpro7 left a comment

Yes, that makes sense.

BalduinLandolt and others added 2 commits Feb 4, 2021
@subotic
Copy link
Collaborator

@subotic subotic commented Feb 4, 2021

@BalduinLandolt I have changed the targets a bit. Could you please take a quick look and try it out?

@BalduinLandolt BalduinLandolt merged commit 9c1a70a into main Feb 4, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@BalduinLandolt BalduinLandolt deleted the wip/DSP-1289-add-metadata-make-targets branch Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants