Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Lists): Shift the second of two children after deletion of the first (DSP-1353) #1820

Merged

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Feb 15, 2021

resolves DSP-1353

…tion of the first one.
Copy link
Collaborator

@benjamingeer benjamingeer left a comment

One good thing about off-by-one errors is that they're easy to fix. :)

@mdelez
mdelez approved these changes Feb 16, 2021
Copy link

@mdelez mdelez left a comment

Thank you!!

@SepidehAlassi SepidehAlassi merged commit d92bb01 into main Feb 16, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1353-ShiftSecondNodeAfterDeletionOfFirst branch Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants