feat(projects): add default set of permissions when creating new project (DSP-1347) #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject Admin and members for operations on entities that belong to this project.
…for a new project
…g to create a permission
subotic
reviewed
Feb 16, 2021
| createRequest.forProject, | ||
| createRequest.forGroup, | ||
| requestingUser = KnoraSystemInstances.Users.SystemUser | ||
| ) | ||
|
|
||
| _ = checkResult match { | ||
| case Some(ap) => | ||
| case Some(ap: AdministrativePermissionADM) => |
subotic
approved these changes
Feb 16, 2021
|
|
||
| // Give the members of the new project rights to modify, view, and restricted view of all resources and values | ||
| // that belong to the project. | ||
| doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
There was a problem hiding this comment.
Shouldn't this be named doapForProjectMember?
|
|
||
| // Give the admins of the new project rights to change rights, modify, delete, view, | ||
| // and restricted view of all resources and values that belong to the project. | ||
| doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
There was a problem hiding this comment.
typo: doapForProjectAdmin
| )).mapTo[AdministrativePermissionCreateResponseADM] | ||
|
|
||
| // Give the members of the new project rights to create resources. | ||
| apPermissionForProjectAdmin: AdministrativePermissionCreateResponseADM <- (responderManager ? AdministrativePermissionCreateRequestADM( |
There was a problem hiding this comment.
apPermissionsForProjectAdmin -> apPermissionsForProjectMember
|
@subotic Thanks for reviewing this and pointing out the typos! :-D |
SepidehAlassi
deleted the
wip/DSP-1347-defaultSetOfPermissionsWhenCreatingProject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1347