Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): add default set of permissions when creating new project (DSP-1347) #1822

Merged

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Feb 16, 2021

resolves DSP-1347

…roject Admin and members for operations on entities that belong to this project.
…g to create a permission
@SepidehAlassi SepidehAlassi requested review from subotic and benjamingeer Feb 16, 2021
createRequest.forProject,
createRequest.forGroup,
requestingUser = KnoraSystemInstances.Users.SystemUser
)

_ = checkResult match {
case Some(ap) =>
case Some(ap: AdministrativePermissionADM) =>

This comment has been minimized.

@subotic

subotic Feb 16, 2021
Collaborator

good catch!

Copy link
Collaborator

@subotic subotic left a comment

Thanks! Just a few minor things.


// Give the members of the new project rights to modify, view, and restricted view of all resources and values
// that belong to the project.
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM(

This comment has been minimized.

@subotic

subotic Feb 16, 2021
Collaborator

Shouldn't this be named doapForProjectMember?


// Give the admins of the new project rights to change rights, modify, delete, view,
// and restricted view of all resources and values that belong to the project.
doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM(

This comment has been minimized.

@subotic

subotic Feb 16, 2021
Collaborator

typo: doapForProjectAdmin

)).mapTo[AdministrativePermissionCreateResponseADM]

// Give the members of the new project rights to create resources.
apPermissionForProjectAdmin: AdministrativePermissionCreateResponseADM <- (responderManager ? AdministrativePermissionCreateRequestADM(

This comment has been minimized.

@subotic

subotic Feb 16, 2021
Collaborator

apPermissionsForProjectAdmin -> apPermissionsForProjectMember

@SepidehAlassi
Copy link
Contributor Author

@SepidehAlassi SepidehAlassi commented Feb 17, 2021

@subotic Thanks for reviewing this and pointing out the typos! :-D

@SepidehAlassi SepidehAlassi merged commit b7c71ca into main Feb 17, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1347-defaultSetOfPermissionsWhenCreatingProject branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants