feat(projects): add default set of permissions when creating new project (DSP-1347) #1822
Conversation
…roject Admin and members for operations on entities that belong to this project.
…for a new project
…g to create a permission
| createRequest.forProject, | ||
| createRequest.forGroup, | ||
| requestingUser = KnoraSystemInstances.Users.SystemUser | ||
| ) | ||
|
|
||
| _ = checkResult match { | ||
| case Some(ap) => | ||
| case Some(ap: AdministrativePermissionADM) => |
subotic
Feb 16, 2021
Collaborator
good catch!
good catch!
|
Thanks! Just a few minor things. |
|
|
||
| // Give the members of the new project rights to modify, view, and restricted view of all resources and values | ||
| // that belong to the project. | ||
| doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
subotic
Feb 16, 2021
Collaborator
Shouldn't this be named doapForProjectMember?
Shouldn't this be named doapForProjectMember?
|
|
||
| // Give the admins of the new project rights to change rights, modify, delete, view, | ||
| // and restricted view of all resources and values that belong to the project. | ||
| doapForProjctAdmin <- (responderManager ? DefaultObjectAccessPermissionCreateRequestADM( |
subotic
Feb 16, 2021
Collaborator
typo: doapForProjectAdmin
typo: doapForProjectAdmin
| )).mapTo[AdministrativePermissionCreateResponseADM] | ||
|
|
||
| // Give the members of the new project rights to create resources. | ||
| apPermissionForProjectAdmin: AdministrativePermissionCreateResponseADM <- (responderManager ? AdministrativePermissionCreateRequestADM( |
subotic
Feb 16, 2021
Collaborator
apPermissionsForProjectAdmin -> apPermissionsForProjectMember
apPermissionsForProjectAdmin -> apPermissionsForProjectMember
|
@subotic Thanks for reviewing this and pointing out the typos! :-D |
SepidehAlassi
deleted the
wip/DSP-1347-defaultSetOfPermissionsWhenCreatingProject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
resolves DSP-1347