Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OntologyResponderV2): Fix check when updating ontology label and comment (DSP-1390) #1826

Merged
merged 6 commits into from Mar 11, 2021

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Mar 3, 2021

resolves DSP-1390
resolves DSP-1397

…y label and comment.
@benjamingeer benjamingeer self-assigned this Mar 3, 2021
@mdelez
Copy link

@mdelez mdelez commented Mar 3, 2021

Looks good to me! Could you also add some logic to allow an empty string for a comment? I don't believe comments are required and currently there is no way to remove a comment once one is provided.

@benjamingeer
Copy link
Collaborator Author

@benjamingeer benjamingeer commented Mar 3, 2021

@mdelez Thanks!

Could you also add some logic to allow an empty string for a comment?

We don't allow empty strings in the triplestore, so I guess we have two options:

  1. Change the semantics of that route so that if you don't provide a comment, the existing comment is removed.
  2. Add a separate route for deleting the comment.

Please open a separate YouTrack issue for this indicating which you prefer.

@mdelez
Copy link

@mdelez mdelez commented Mar 3, 2021

separate Youtrack issue has been made https://dasch.myjetbrains.com/youtrack/issue/DSP-1397

@benjamingeer benjamingeer requested review from subotic and SepidehAlassi Mar 3, 2021
benjamingeer added 4 commits Mar 4, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This is great, thank you!

@benjamingeer benjamingeer merged commit 26cce48 into main Mar 11, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the fix/DSP-1390-label-comment branch Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants