Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OntologiesRouteV2): Reject internal ontology names in external schema (DSP-1394) #1827

Merged
merged 4 commits into from Mar 11, 2021

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Mar 3, 2021

resolves DSP-1394

@benjamingeer benjamingeer self-assigned this Mar 3, 2021
@benjamingeer benjamingeer requested review from subotic and SepidehAlassi Mar 3, 2021
benjamingeer added 2 commits Mar 8, 2021
*/
def checkExternalOntologyName(iri: SmartIri): Unit = {
if (iri.isKnoraApiV2DefinitionIri && OntologyConstants.InternalOntologyLabels.contains(iri.getOntologyName)) {
throw BadRequestException(s"Invalid IRI: <$iri>")

This comment has been minimized.

@SepidehAlassi

SepidehAlassi Mar 11, 2021
Contributor

@benjamingeer don't you think it might be better to throw a more clear exception message indicating that internal ontologies cannot be served?

This comment has been minimized.

@benjamingeer

benjamingeer Mar 11, 2021
Author Collaborator

Done: 05a7ba1

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Perfect, thanks!

@benjamingeer benjamingeer merged commit e392bf1 into main Mar 11, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the fix/DSP-1394-ontologies branch Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants