Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Improve error message when an XSLT transformation file is not found (DSP-1404) #1831

Merged
merged 6 commits into from Mar 15, 2021

Conversation

@benjamingeer
Copy link
Collaborator

@benjamingeer benjamingeer commented Mar 12, 2021

If a default XSL transformation isn't found for a standoff mapping, returns an error message like:

org.knora.webapi.exceptions.SipiException: Default XSL transformation
<http://rdfh.ch/0801/smVjS18pSpyBm_TeTiXuoA> not found for mapping
<http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF/mappings/leooLetterMapping>:
Unable to get file http://sipi:1024/0801/3QlCAYIGInS-G2RGy0nWAkk/file from Sipi as requested by
org.knora.webapi.responders.v2.StandoffResponderV2: Not Found"

resolves DSP-1404

@benjamingeer benjamingeer self-assigned this Mar 12, 2021
@benjamingeer benjamingeer requested a review from SepidehAlassi Mar 12, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This is great, thanks!

xslTransformation: GetXSLTransformationResponseV2 <- (responderManager ? teiHeaderXsltRequest)
.mapTo[GetXSLTransformationResponseV2]
} yield Some(xslTransformation.xslt)

xslTransformationFuture.recover {

This comment has been minimized.

@SepidehAlassi

SepidehAlassi Mar 15, 2021
Contributor

wieder was gelernt! This recover combinator is super cool :-)

@benjamingeer benjamingeer merged commit 153a674 into main Mar 15, 2021
11 checks passed
11 checks passed
Build Everything
Details
Prepare next release
Details
Test client-test-data
Details
API Unit Tests
Details
API E2E Tests
Details
API Integration Tests
Details
Upgrade Integration Tests
Details
Docs Build Test
Details
Publish (on release only)
Details
Deploy docs (on release only)
Details
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the wip/DSP-1404-sipi branch Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants