Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gravsearch): Keep rdf:type knora-api:Resource when needed (DSP-1407) #1835

merged 1 commit into from Mar 24, 2021


Copy link

@benjamingeer benjamingeer commented Mar 23, 2021

resolves DSP-1407

  • Don't assume that rdf:type knora-api:Resource is always a Gravsearch type annotation and remove it.
  • Add an optimisation that removes rdf:type knora-api:Resource if there's another statement at the same level of the WHERE clause with the same subject and predicate and a different type IRI.

@benjamingeer benjamingeer self-assigned this Mar 23, 2021
@benjamingeer benjamingeer added API/V2 bug something isn't working Gravsearch labels Mar 23, 2021
Copy link

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks.

Copy link

Thanks for the review!

@benjamingeer benjamingeer merged commit e561d94 into main Mar 24, 2021
@benjamingeer benjamingeer deleted the fix/DSP-1407-gravsearch branch March 24, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
API/V2 bug something isn't working Gravsearch
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants