Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gravsearch): Keep rdf:type knora-api:Resource when needed (DSP-1407) #1835

Merged
merged 1 commit into from Mar 24, 2021

Conversation

@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented Mar 23, 2021

resolves DSP-1407

  • Don't assume that rdf:type knora-api:Resource is always a Gravsearch type annotation and remove it.
  • Add an optimisation that removes rdf:type knora-api:Resource if there's another statement at the same level of the WHERE clause with the same subject and predicate and a different type IRI.
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This is great, thanks.

@benjamingeer
Copy link
Contributor Author

@benjamingeer benjamingeer commented Mar 24, 2021

Thanks for the review!

@benjamingeer benjamingeer merged commit e561d94 into main Mar 24, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the fix/DSP-1407-gravsearch branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants