Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-v2): Add route for changing GUI order of cardinalities #1850

Merged
merged 10 commits into from May 3, 2021

Conversation

@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented Apr 26, 2021

resolves DSP-1546

@benjamingeer benjamingeer marked this pull request as draft Apr 26, 2021
Benjamin Geer added 4 commits Apr 26, 2021
# Conflicts:
#	webapi/src/main/scala/org/knora/webapi/messages/StringFormatter.scala
#	webapi/src/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
@benjamingeer benjamingeer marked this pull request as ready for review Apr 27, 2021
@benjamingeer benjamingeer requested a review from SepidehAlassi Apr 27, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

This looks great, thanks.

| "owl:onProperty": {
| "@id" : "anything:hasNothingness"
| },
| "salsah-gui:guiOrder": 2

This comment has been minimized.

@SepidehAlassi

SepidehAlassi Apr 29, 2021
Contributor

Please fix this indentation.

Put("/v2/ontologies/guiorder", HttpEntity(RdfMediaTypes.`application/ld+json`, params)) ~> addCredentials(
BasicHttpCredentials(anythingUsername, password)) ~> ontologiesPath ~> check {
assert(status == StatusCodes.OK, response.toString)
val responseJsonDoc = responseToJsonLDDocument(response)

This comment has been minimized.

@SepidehAlassi

SepidehAlassi Apr 29, 2021
Contributor

please also add the response to the client test data as change-gui-order-response.json

@benjamingeer benjamingeer merged commit d8dbb4f into main May 3, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the wip/DSP-1546_updateGuiOrderRoute branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants