Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gravsearch): don't move the patterns with resource IRI after topological sorting (DSP-1620) #1856

Merged

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented May 11, 2021

resolves DSP-1620

For optimization of Gravsearch queries, we define a graph out of a given query for topological sorting. A resource IRI given as the subject or object of a query pattern would be a node of the graph. Therefore the topological sorting algorithm would already order these patterns properly with respect to other patterns in the query. Extra use of moveResourceIrisToBeginning would mess with this order, therefore now that we have topological sorting of patterns in place, this method is obsolete and has to be removed.

@SepidehAlassi SepidehAlassi changed the title fix(gravsearch): don't move the patterns with resource IRI after topological sorting fix(gravsearch): don't move the patterns with resource IRI after topological sorting (DSP-1620) May 11, 2021
Copy link
Contributor

@benjamingeer benjamingeer left a comment

Thanks for taking care of this!

@SepidehAlassi
Copy link
Contributor Author

@SepidehAlassi SepidehAlassi commented May 12, 2021

@benjamingeer thanks for reviewing this.

@SepidehAlassi SepidehAlassi merged commit 6022c91 into main May 12, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1620-removeObsoletePatternOptimizationRule branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants