Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sipi): create tmp folder #1864

Merged
merged 9 commits into from May 30, 2021
Merged

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented May 27, 2021

resolves DSP-1679

During upload there is a check if the tmp folder exists. If not, then the script should not throw an error but create the tmp folder.

@subotic subotic self-assigned this May 27, 2021
@subotic subotic requested a review from benjamingeer May 27, 2021
@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented May 27, 2021

Tests failing: Sipi is returning Internal server error.

@subotic
Copy link
Collaborator Author

@subotic subotic commented May 27, 2021

Tests failing: Sipi is returning Internal server error.

yes, unfortunately. Tests are only failing on Github-CI. Locally they are running through.

@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented May 28, 2021

Tests are only failing on Github-CI. Locally they are running through.

I don't understand why that's OK, but I guess you know what you're doing. 🙂

@subotic
Copy link
Collaborator Author

@subotic subotic commented May 28, 2021

Tests are only failing on Github-CI. Locally they are running through.

I don't understand why that's OK, but I guess you know what you're doing. 🙂

It is not ;-) I'm not going to merge before the tests run through. At the moment, I have no idea why those tests fail. The change introduced in this PR is not what makes the tests fail. At least, I don't see how it can.

@subotic
Copy link
Collaborator Author

@subotic subotic commented May 30, 2021

Tests are only failing on Github-CI. Locally they are running through.

I don't understand why that's OK, but I guess you know what you're doing. 🙂

It is not ;-) I'm not going to merge before the tests run through. At the moment, I have no idea why those tests fail. The change introduced in this PR is not what makes the tests fail. At least, I don't see how it can.

Found the problem. Lua is a very obscure language. My change was the problem. I have reverted it and added some comments for the next poor soul who has to deal with Lua.

@subotic subotic merged commit 06e8b0c into main May 30, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@subotic subotic deleted the wip/DSP-1679-Improve-sipi-upload-script branch May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants