Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cache-service): add in-memory implementation #1870

Merged
merged 18 commits into from Jun 15, 2021

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented Jun 5, 2021

resolves DSP-1658

  • refactoring: divide into abstract and concrete cache service implementation
  • feature: add in-memory cache implementation
  • feature: hardcode the new in-memory cache implementation as the new default
  • test: add unit tests for in-memory implementation
  • test: add integration tests using Testcontainers for the Redis implementation
  • test: remove redis container from all other integration/e2e tests
  • refactoring: extract cache settings into separate settings class
  • refactoring: provide cache settings at startup
  • refactoring: fix a number of deprecation warnings
  • build cleanup
@subotic subotic self-assigned this Jun 5, 2021
@kilchenmann kilchenmann changed the title feature (cache-service): add cache service in-memory implementation feature(cache-service): add cache service in-memory implementation Jun 8, 2021
@subotic subotic requested a review from SepidehAlassi Jun 14, 2021
@subotic subotic changed the title feature(cache-service): add cache service in-memory implementation feature(cache-service): add in-memory implementation Jun 14, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

LGTM, however, before merging please take care of mentioned comments.

@subotic
Copy link
Collaborator Author

@subotic subotic commented Jun 15, 2021

@SepidehAlassi thanks for the review :-)

@subotic subotic merged commit 61531ab into main Jun 15, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@subotic subotic deleted the wip/DSP-1658-Add-in-memory-cache-implementation branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants