Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(cache-service): add in-memory implementation #1870

Merged
merged 18 commits into from Jun 15, 2021
Merged

feature(cache-service): add in-memory implementation #1870

merged 18 commits into from Jun 15, 2021

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Jun 5, 2021 •
edited

resolves DSP-1658

  • refactoring: divide into abstract and concrete cache service implementation
  • feature: add in-memory cache implementation
  • feature: hardcode the new in-memory cache implementation as the new default
  • test: add unit tests for in-memory implementation
  • test: add integration tests using Testcontainers for the Redis implementation
  • test: remove redis container from all other integration/e2e tests
  • refactoring: extract cache settings into separate settings class
  • refactoring: provide cache settings at startup
  • refactoring: fix a number of deprecation warnings
  • build cleanup

@subotic subotic self-assigned this Jun 5, 2021
@kilchenmann kilchenmann changed the title feature (cache-service): add cache service in-memory implementation feature(cache-service): add cache service in-memory implementation Jun 8, 2021
@subotic subotic changed the title feature(cache-service): add cache service in-memory implementation feature(cache-service): add in-memory implementation Jun 14, 2021
SepidehAlassi
SepidehAlassi approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, before merging please take care of mentioned comments.

webapi/src/main/scala/org/knora/webapi/settings/KnoraSettings.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/inmem/CacheServiceInMemImpl.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/inmem/CacheServiceInMemImpl.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/inmem/CacheServiceInMemImpl.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/inmem/CacheServiceInMemImpl.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/redis/CacheServiceRedisImpl.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/redis/CacheServiceRedisImpl.scala Outdated Show resolved Hide resolved
@subotic
Copy link
Collaborator Author

subotic commented Jun 15, 2021

@SepidehAlassi thanks for the review :-)

@subotic subotic merged commit 61531ab into main Jun 15, 2021
@subotic subotic deleted the wip/DSP-1658-Add-in-memory-cache-implementation branch June 15, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SepidehAlassi SepidehAlassi SepidehAlassi approved these changes

Assignees

@subotic subotic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subotic @SepidehAlassi